Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fuselage): Contextualbar component #749

Merged
merged 6 commits into from
May 24, 2023
Merged

Conversation

PedroRorato
Copy link
Contributor

@PedroRorato PedroRorato commented Jun 21, 2022

Proposed changes (including videos or screenshots)

Issue(s)

Further comments

DSAR-166

@CLAassistant
Copy link

CLAassistant commented Aug 10, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@dougfabris dougfabris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice move on this one mate. I would suggest you avoid Box on the components we're moving to the Fuselage.
Also, I would like to share this new documentation, so you can take a look and tell me if it would help future developments related to components. Any contributions are welcome as well 😄

@dougfabris dougfabris changed the title feat(fuselage): create ContextualBar component feat(fuselage): VerticalBar component May 22, 2023
@dougfabris dougfabris changed the title feat(fuselage): VerticalBar component feat(fuselage): Verticalbar component May 22, 2023
@dougfabris dougfabris changed the title feat(fuselage): Verticalbar component feat(fuselage): Contextualbar component May 23, 2023
@dougfabris dougfabris marked this pull request as ready for review May 23, 2023 18:24
@ggazzo ggazzo merged commit e2f7453 into develop May 24, 2023
@ggazzo ggazzo deleted the feat-contextual-bar branch May 24, 2023 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants