Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fuselage): Modal wrapper & wrapperFunction prop #959

Merged
merged 3 commits into from
Jan 24, 2023

Conversation

dougfabris
Copy link
Member

@dougfabris dougfabris commented Jan 23, 2023

Proposed changes (including videos or screenshots)

This PR introduces two options to pass a wrapper component to the Modal:

  • wrapper: for stateful components
  • wrapperFunction: for stateless components

Issue(s)

Further comments

@dougfabris dougfabris marked this pull request as draft January 23, 2023 21:27
@dougfabris dougfabris marked this pull request as ready for review January 24, 2023 15:19
@dougfabris dougfabris changed the title feat(fuselage): Modal wrapper prop feat(fuselage): Modal wrapper & wrapperFunction prop Jan 24, 2023
@dougfabris dougfabris merged commit 4493328 into develop Jan 24, 2023
@dougfabris dougfabris deleted the feat/modal-wrapper branch January 24, 2023 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants