Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plans for the next bigger update #226

Open
2 of 4 tasks
RonRadtke opened this issue Mar 3, 2023 · 3 comments
Open
2 of 4 tasks

Plans for the next bigger update #226

RonRadtke opened this issue Mar 3, 2023 · 3 comments

Comments

@RonRadtke
Copy link
Owner

RonRadtke commented Mar 3, 2023

Hi,
I'm gathering ToDos for the next bigger release. If anyone has wishes, wants to help or any concerns, please comment.
This will also result in the very first major version update.

  • reorganize the JS API and remove some undocumented exported functions
  • rewrite js code to use the NativeEventEmitter
  • rewrite native code to use RCTEventEmitter instead of RCTDeviceEventEmitter or similar. (https://reactnative.dev/docs/native-modules-ios#sending-events-to-javascript)
  • Check if (on android) all Requests are clean up (BroadcastReceiver is getting registered too often per PID)
@RonRadtke RonRadtke pinned this issue Mar 3, 2023
@RonRadtke RonRadtke changed the title Plan for the next Version Plans for the next Version Mar 3, 2023
@RonRadtke RonRadtke changed the title Plans for the next Version Plans for the next bigger update Mar 3, 2023
@RonRadtke
Copy link
Owner Author

The eventemitter part is rewritten and went live already as part as the last versions.
Due to bugs on ios i had to integrate it directly and could not wait for the my other plans being done.
On Android I just did the necessary adjustments but not changing the native emitter part since there is currently a lot going on in react-native and the new architecture/bridgless and it's cure unclear (for me) what will be the long term way to go.

@Fuzzyma
Copy link

Fuzzyma commented Oct 27, 2023

hey @RonRadtke! I have a request which might make this repo more accessible for beginners of react-native (like me :D).
Could you publish this package as expo module as well?

Atm, it is only possible to use this package with a development build of expo which makes the whole process of getting started 10x more complicated than it could be.

I imagine that the expo build could be done automatically when you release a new version of this package, right? In that case its a one time cost for setting it up and will (hopefully) just work from there

@crackhack8266
Copy link

@RonRadtke please add background download support for ios with an example please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants