Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_all_files_already_beautiful contains wisdom beautify_changed_files_in_branch needs #65

Open
smlewis opened this issue May 4, 2018 · 0 comments

Comments

@smlewis
Copy link
Member

smlewis commented May 4, 2018

https://github.com/RosettaCommons/tools/blob/master/python_cc_reader/test_all_files_already_beautiful.py#L36

print "One of the most likely reasons your file doesn't compile is that you have used a macro (e.g. TS_ASSERT) but have not followed it with a semicolon"

This warning is absolutely brilliant, and it is a shame that the user can only see it after the TEST SERVER fails to beautify. If they run beautify_changed_files_in_branch locally, it just tells them it can't do it because of mismatched {} without the helpful error message. Perhaps the message can migrate.

(I can do the idiot's version of "just always print the message" but I bet it is a 2 minute job for @aleaverfay to do the slicker "only print it if it failed on a cxxtest file").

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant