diff --git a/spec/bank/base_spec.rb b/spec/bank/base_spec.rb index e5976eff7c..061efac074 100644 --- a/spec/bank/base_spec.rb +++ b/spec/bank/base_spec.rb @@ -32,25 +32,25 @@ def setup describe "#exchange_with" do it "is not implemented" do - expect { subject.exchange_with(Money.new(100, 'USD'), 'EUR') }.to raise_exception(NotImplementedError) + expect { subject.exchange_with(Money.new(100, 'USD'), 'EUR') }.to raise_error(NotImplementedError) end end describe "#same_currency?" do it "accepts str/str" do - expect { subject.send(:same_currency?, 'USD', 'EUR') }.to_not raise_exception + expect { subject.send(:same_currency?, 'USD', 'EUR') }.to_not raise_error end it "accepts currency/str" do - expect { subject.send(:same_currency?, Money::Currency.wrap('USD'), 'EUR') }.to_not raise_exception + expect { subject.send(:same_currency?, Money::Currency.wrap('USD'), 'EUR') }.to_not raise_error end it "accepts str/currency" do - expect { subject.send(:same_currency?, 'USD', Money::Currency.wrap('EUR')) }.to_not raise_exception + expect { subject.send(:same_currency?, 'USD', Money::Currency.wrap('EUR')) }.to_not raise_error end it "accepts currency/currency" do - expect { subject.send(:same_currency?, Money::Currency.wrap('USD'), Money::Currency.wrap('EUR')) }.to_not raise_exception + expect { subject.send(:same_currency?, Money::Currency.wrap('USD'), Money::Currency.wrap('EUR')) }.to_not raise_error end it "returns true when currencies match" do @@ -67,8 +67,8 @@ def setup expect(subject.send(:same_currency?, Money::Currency.wrap('USD'), Money::Currency.wrap('EUR'))).to be false end - it "raises an UnknownCurrency exception when an unknown currency is passed" do - expect { subject.send(:same_currency?, 'AAA', 'BBB') }.to raise_exception(Money::Currency::UnknownCurrency) + it "raises an UnknownCurrency error when an unknown currency is passed" do + expect { subject.send(:same_currency?, 'AAA', 'BBB') }.to raise_error(Money::Currency::UnknownCurrency) end end end diff --git a/spec/bank/single_currency_spec.rb b/spec/bank/single_currency_spec.rb index 9be78aeb5c..93cd318340 100644 --- a/spec/bank/single_currency_spec.rb +++ b/spec/bank/single_currency_spec.rb @@ -3,7 +3,7 @@ it "raises when called" do expect { subject.exchange_with(Money.new(100, 'USD'), 'EUR') - }.to raise_exception(Money::Bank::DifferentCurrencyError, "No exchanging of currencies allowed: 1.00 USD to EUR") + }.to raise_error(Money::Bank::DifferentCurrencyError, "No exchanging of currencies allowed: 1.00 USD to EUR") end end end diff --git a/spec/bank/variable_exchange_spec.rb b/spec/bank/variable_exchange_spec.rb index 2c645dea6f..4237a58e46 100644 --- a/spec/bank/variable_exchange_spec.rb +++ b/spec/bank/variable_exchange_spec.rb @@ -33,11 +33,11 @@ describe "#exchange_with" do it "accepts str" do - expect { bank.exchange_with(Money.new(100, 'USD'), 'EUR') }.to_not raise_exception + expect { bank.exchange_with(Money.new(100, 'USD'), 'EUR') }.to_not raise_error end it "accepts currency" do - expect { bank.exchange_with(Money.new(100, 'USD'), Money::Currency.wrap('EUR')) }.to_not raise_exception + expect { bank.exchange_with(Money.new(100, 'USD'), Money::Currency.wrap('EUR')) }.to_not raise_error end it "exchanges one currency to another" do @@ -48,12 +48,12 @@ expect(bank.exchange_with(Money.new(10, 'USD'), 'EUR')).to eq Money.new(13, 'EUR') end - it "raises an UnknownCurrency exception when an unknown currency is requested" do - expect { bank.exchange_with(Money.new(100, 'USD'), 'BBB') }.to raise_exception(Money::Currency::UnknownCurrency) + it "raises an UnknownCurrency error when an unknown currency is requested" do + expect { bank.exchange_with(Money.new(100, 'USD'), 'BBB') }.to raise_error(Money::Currency::UnknownCurrency) end - it "raises an UnknownRate exception when an unknown rate is requested" do - expect { bank.exchange_with(Money.new(100, 'USD'), 'JPY') }.to raise_exception(Money::Bank::UnknownRate) + it "raises an UnknownRate error when an unknown rate is requested" do + expect { bank.exchange_with(Money.new(100, 'USD'), 'JPY') }.to raise_error(Money::Bank::UnknownRate) end #it "rounds the exchanged result down" do @@ -136,8 +136,8 @@ expect(subject.store.get_rate('USD', 'EUR')).to eq 1.25 end - it "raises an UnknownCurrency exception when an unknown currency is passed" do - expect { subject.set_rate('AAA', 'BBB', 1.25) }.to raise_exception(Money::Currency::UnknownCurrency) + it "raises an UnknownCurrency error when an unknown currency is passed" do + expect { subject.set_rate('AAA', 'BBB', 1.25) }.to raise_error(Money::Currency::UnknownCurrency) end end @@ -147,8 +147,8 @@ expect(subject.get_rate('USD', 'EUR')).to eq 1.25 end - it "raises an UnknownCurrency exception when an unknown currency is passed" do - expect { subject.get_rate('AAA', 'BBB') }.to raise_exception(Money::Currency::UnknownCurrency) + it "raises an UnknownCurrency error when an unknown currency is passed" do + expect { subject.get_rate('AAA', 'BBB') }.to raise_error(Money::Currency::UnknownCurrency) end it "delegates options to store, options are a no-op" do diff --git a/spec/currency_spec.rb b/spec/currency_spec.rb index f91d15186c..2e01018bbc 100644 --- a/spec/currency_spec.rb +++ b/spec/currency_spec.rb @@ -367,7 +367,7 @@ def to_s end it "doesn't create new symbols indefinitely" do - expect { described_class.new("bogus") }.to raise_exception(described_class::UnknownCurrency) + expect { described_class.new("bogus") }.to raise_error(described_class::UnknownCurrency) expect(Symbol.all_symbols.map{|s| s.to_s}).not_to include("bogus") end end diff --git a/spec/money/arithmetic_spec.rb b/spec/money/arithmetic_spec.rb index 336212d9bd..3f43256361 100644 --- a/spec/money/arithmetic_spec.rb +++ b/spec/money/arithmetic_spec.rb @@ -673,19 +673,19 @@ it "raises TypeError dividing by a Money (unless other is a Money)" do expect { 2 / Money.new(2, 'USD') - }.to raise_exception(TypeError) + }.to raise_error(TypeError) end it "raises TypeError subtracting by a Money (unless other is a Money)" do expect { 2 - Money.new(2, 'USD') - }.to raise_exception(TypeError) + }.to raise_error(TypeError) end it "raises TypeError adding by a Money (unless other is a Money)" do expect { 2 + Money.new(2, 'USD') - }.to raise_exception(TypeError) + }.to raise_error(TypeError) end it "allows subtraction from numeric zero" do @@ -701,7 +701,7 @@ it "treats multiplication as commutative" do expect { 2 * Money.new(2, 'USD') - }.to_not raise_exception + }.to_not raise_error result = 2 * Money.new(2, 'USD') expect(result).to eq(Money.new(4, 'USD')) end @@ -709,25 +709,25 @@ it "doesn't work with non-numerics" do expect { "2" * Money.new(2, 'USD') - }.to raise_exception(TypeError) + }.to raise_error(TypeError) end it "correctly handles <=>" do expect { 2 < Money.new(2, 'USD') - }.to raise_exception(ArgumentError) + }.to raise_error(ArgumentError) expect { 2 > Money.new(2, 'USD') - }.to raise_exception(ArgumentError) + }.to raise_error(ArgumentError) expect { 2 <= Money.new(2, 'USD') - }.to raise_exception(ArgumentError) + }.to raise_error(ArgumentError) expect { 2 >= Money.new(2, 'USD') - }.to raise_exception(ArgumentError) + }.to raise_error(ArgumentError) expect(2 <=> Money.new(2, 'USD')).to be_nil end @@ -738,18 +738,18 @@ expect(0.0 >= Money.usd(0)).to eq true end - it "raises exceptions for all numeric types, not just Integer" do + it "raises errors for all numeric types, not just Integer" do expect { 2.0 / Money.new(2, 'USD') - }.to raise_exception(TypeError) + }.to raise_error(TypeError) expect { Rational(2,3) / Money.new(2, 'USD') - }.to raise_exception(TypeError) + }.to raise_error(TypeError) expect { BigDecimal(2) / Money.new(2, 'USD') - }.to raise_exception(TypeError) + }.to raise_error(TypeError) end end diff --git a/spec/money_spec.rb b/spec/money_spec.rb index d8231b9b5d..bfba7b5255 100644 --- a/spec/money_spec.rb +++ b/spec/money_spec.rb @@ -160,7 +160,7 @@ it "disallows conversions when doing money arithmetic" do Money.disallow_currency_conversion! - expect { Money.new(100, "USD") + Money.new(100, "EUR") }.to raise_exception(Money::Bank::DifferentCurrencyError) + expect { Money.new(100, "USD") + Money.new(100, "EUR") }.to raise_error(Money::Bank::DifferentCurrencyError) end end @@ -417,7 +417,7 @@ def expectation.fractional expect(money.round_to_nearest_cash_value).to eq(-301) end - it "raises an exception if smallest denomination is not defined" do + it "raises an error if smallest denomination is not defined" do money = Money.new(100, "XAG") expect {money.round_to_nearest_cash_value}.to raise_error(Money::UndefinedSmallestDenomination) end