Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to node-gyp@3.x #275

Closed
sam-github opened this issue Aug 4, 2016 · 3 comments
Closed

upgrade to node-gyp@3.x #275

sam-github opened this issue Aug 4, 2016 · 3 comments

Comments

@sam-github
Copy link
Contributor

I'd PR a change for this, but I'm not sure how to test.

Despite that it jumps a major, I suspect that it does not introduce a compatibility problem for appmetrics (and anyhow, the use of graceful-fs@3 that node-gyp@2 pulls in is going to break real soon know in node).

The change that caused the node-gyp major to bump is nodejs/node-gyp#708, FYI, which is why I don't think its going to be a problem.

@sam-github
Copy link
Contributor Author

sam-github commented Oct 7, 2016

Actually, there is no need for appmetrics to depend on node-gyp, its builtin to npm. I suggest deleting both these lines:

@sjanuary
Copy link
Contributor

I think we've got a separate PR for removing the node-gyp dependency so I'm going to close this now

@NikCanvin
Copy link
Collaborator

separate PR for removing the node-gyp dependency #288

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants