-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade to node-gyp@3.x #275
Comments
Actually, there is no need for appmetrics to depend on node-gyp, its builtin to npm. I suggest deleting both these lines: |
I think we've got a separate PR for removing the node-gyp dependency so I'm going to close this now |
separate PR for removing the node-gyp dependency #288 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'd PR a change for this, but I'm not sure how to test.
Despite that it jumps a major, I suspect that it does not introduce a compatibility problem for appmetrics (and anyhow, the use of graceful-fs@3 that node-gyp@2 pulls in is going to break real soon know in node).
The change that caused the node-gyp major to bump is nodejs/node-gyp#708, FYI, which is why I don't think its going to be a problem.
The text was updated successfully, but these errors were encountered: