Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio capture is unsupported #625

Closed
tbu- opened this issue Apr 2, 2017 · 4 comments
Closed

Audio capture is unsupported #625

tbu- opened this issue Apr 2, 2017 · 4 comments
Milestone

Comments

@tbu-
Copy link

tbu- commented Apr 2, 2017

The isplayback parameter of SDL_OpenAudioDevice is just set to 0 instead of being taken from the user.

@Cobrand
Copy link
Member

Cobrand commented Apr 5, 2017

The audio part of SDL2 was made long ago by someone else who probably shaped sdl2_mixer however they wanted to use it at the time. I for one didn't even know you could capture anything with SDL2, that's quite the news. I don't have much time to fix that at the moment, but I'd be happy to review any PR made about this issue ! If you or anyone else would like to fix that, fell free !

@Cobrand
Copy link
Member

Cobrand commented Apr 11, 2017

Turns out that audio recording is actually quite new, SDL 2.0.5 new actually, and it was only out a few months ago ... That must be why it wasn't implemented before.

The issue stays the same, but since this crate hasn't been actively developed in a long time, no wonder why audio capture isn't supported yet !

@shybyte
Copy link
Contributor

shybyte commented Jun 7, 2017

I'm thinking about working on a PR for this feature, but 2 reasons stop me:

@Cobrand
Copy link
Member

Cobrand commented Jun 7, 2017

If you want to to a PR, go ahead! They are always welcome! My overhaul was a plan for the long term, I haven't started to look into it yet. As with everything, I'd like to look into it as soon as possible, but easier said than done. If someone did a PR implementing that, at least I could sleep on both ears knowing that audio capture is supported even before i make that big overhaul!

Don't worry about Ubuntu LTS not having 2.0.5, I think it's totally fine to implement this either way. It will not impact those not using audio capture and being in 2.0.4, and it can only improve this current crate by adding a new feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants