Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minimp3 causes iOS app store rejection due to slice_deque use #400

Closed
alice-i-cecile opened this issue Nov 18, 2021 · 4 comments
Closed

Comments

@alice-i-cecile
Copy link

alice-i-cecile commented Nov 18, 2021

Heads up, using the mp3 Bevy feature will cause your iOS app to get rejected because minimp3 depends on slice_deque which uses an internal API for memory allocation.

First reported in bevyengine/bevy#3145, but I figured I'd toss it upstream for the rodio team to look at.

@est31
Copy link
Member

est31 commented Nov 18, 2021

Thanks for filing a bug! Outside of removing the mp3 feature entirely, it's not very actionable from the point of view of rodio. There are two better places for bugs:

  • The minimp3 repo. They can switch away from slice-dequeue as it seems unmaintained.
  • The slice-deque crate which does the offending internal allocations in the first place. Of course, as it is unmaintained, it is possible that you won't receive much help from its maintainer.

@alice-i-cecile
Copy link
Author

Great; I'll file it upstream on minimp3 and close this out then.

@LiquidityC
Copy link
Contributor

LiquidityC commented Nov 18, 2021

Minimp3 already has a bug filed for this issue from a few months back. I have now created a fork of slice_deque with the issue patched because so long has passed and dropped them a PR for this very issue. 😊

@LiquidityC
Copy link
Contributor

For reference: germangb/minimp3-rs#38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants