Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing constructors for SkEd25519 #200

Closed
jviki opened this issue Mar 4, 2024 · 2 comments
Closed

Missing constructors for SkEd25519 #200

jviki opened this issue Mar 4, 2024 · 2 comments

Comments

@jviki
Copy link
Contributor

jviki commented Mar 4, 2024

I've got sk-ed25519 public key bytes, sk application string, sk flags byte and would like to construct the PrivateKey and write it out in the OpenSSH format. I didn't find out how to do it. It seems like there are missing any constructors or means for constructing the data structs, especially KeypairData and KeyData. Do I miss something or is it currently not possible?

@tarcieri tarcieri changed the title Missing constructors for objects KeypairData and KeyData Missing constructors for SkEd25519 Mar 5, 2024
@tarcieri
Copy link
Member

tarcieri commented Mar 5, 2024

Note that KeypairData and KeyData are both enums with 1-tuple variants, so constructing either of them involves constructing one of the variants first, which is the real issue here.

What's currently missing are constructors for ssh_key::private::SkEd25519 and ssh_key::public::SkEd25519. I've updated the issue title accordingly.

@jviki jviki mentioned this issue Mar 6, 2024
@tarcieri
Copy link
Member

Added in #201

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants