Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Set minimal permissions to GitHub Workflow #993

Closed
diogoteles08 opened this issue Dec 29, 2023 · 2 comments · Fixed by #994
Closed

CI: Set minimal permissions to GitHub Workflow #993

diogoteles08 opened this issue Dec 29, 2023 · 2 comments · Fixed by #994

Comments

@diogoteles08
Copy link
Contributor

Hi!

I'm Diogo and I work at the same Google's team that Joyce, who raised #854.

I'm here to suggest that you set minimal permissions to your GitHub Workflow security-audit.yml, because currently it doesn't specify the permissions for their jobs and their privileges are being determined by GitHub's defaults. If you define minimal permissions, you would be secured against erroneous or malicious behaviours from external jobs you call from your workflow. It's specially important for the case they get compromised, for example.

Since it's a very simple change, I'll raise a PR following this issue and it'll be easier to evaluate the modifications =)

@tarcieri
Copy link
Member

That's fine, however note that we do configure all repos so GitHub Actions has read-only access:

Screenshot 2023-12-29 at 2 29 16 PM

@diogoteles08
Copy link
Contributor Author

Oh that's great! Yes, it should be enough. It's arguable that having the explicit permissions on the files is clearer, but feel free to ignore and close my issues, if you prefer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants