-
Notifications
You must be signed in to change notification settings - Fork 808
Installer does not find .NET installation #3028
Comments
I'm having the same issue on Windows 10 Pro 21H2. The zipped version runs fine. |
same issue here, I've tried all zipped and installer. |
Temporary Workaround - Use 7zip to extract the files from the installer and just then just run the .exe for the program |
Found an error with registry value enumeration with that routine. Although, that error should not have mattered in this case as only one value exists at that key. Also, that installer was still using helper apps compiled against VS 2022 redistributable rather than against 2019 like I wanted; that change might be relevant here. I will get an updated installer link posted here later. Edit: Also found a value error when it came to the return value from wstring::find. Should not be relevant here as the routine should always return true if that problem is encountered. |
DS4Windows_installer_x64_v3.2.13_try2.exe |
Still got the same error from the try2.exe file |
Same for me, shows the same message as before. |
I tried the two executables uploaded and had the same behavior happen. Perhaps it's best to comment out the function that checks for the .net framework and replace it with a dialog box saying this software requires .net framework, such as "if you get an error message such as 'This application could not be started' then you should download the framework from " or something to that nature. |
Same issue for me |
Seriously wondering if this is all just stemming from Windows Defender refusing to allow the helper executables to launch on other people's machines since they are not signed? If it were not for the value enumeration, I would just move the .NET Runtime registry check into the install script. I guess I can just not have the install script exit if it fails to find the registry value. |
I would remove the check completely and just put a popup letting the user know that the program requires .net framework. |
So, is there a solution to this problem yet? As I just tried to use the installer and got this same issue. |
You can install it manually, see https://ds4-windows.com/get-started/ |
Grab the latest .zip file here https://github.com/Ryochan7/DS4Windows/releases/download/v3.2.13/DS4Windows_3.2.13_x64.zip and extract it, then just run the thing. Make sure you have .net framework installed or it won't work. |
I suck. The installer is busted in at least 3 different ways. I was mistaken about my current PC being unable to run Windows 10 in a VM. It is a stretch with 8 GB of RAM but it is doable as long as the host OS isn't running much; I got about 2.5 GB of RAM dedicated to the guest OS. Finally had a test target to use and the installer did not work. The primary problem was due to a misunderstanding about how to deal with temporary bundled executables using NSIS in the first place. The .NET install check was failing because the helper executable could not be found. It was a lot more work to try to resolve the problems with getting the helper executables working properly outside my dev environment. Using the IfErrors call was not the proper check to be using for checking the return code in some cases (when using ExecShellWait). Ended up changing some other checks in the process. Now the installer works in the VM as I originally intended. I will attempt to get an updated installer posted here later today. Not sure it will actually happen though. |
Trying this again DS4Windows_installer_x64_v3.2.13_try3.exe |
Already changed it up. Flagged FakerInput as an optional component. Tbf, FakerInput is a mandatory component for my test mappers and it will stay that way. DS4Windows_installer_x64_v3.2.13_try4.exe |
Again. Used outdated component. Fumbling too much AFK DS4Windows_installer_x64_v3.2.13_try5.exe |
Still same issue for me with try5 |
At this point, it might be the case that the Visual C++ Redistributable 2015-2022 package is not installed on your system; that package is noted as an explicit system requirement for the test mappers. The two helper executables are compiled against Visual C++ 2019 so you need at least that version installed on your PC. I ended up adding an additional check checking if the first executable failed to launch in the NSIS script and warn the user about it. Will get an updated link here in a bit. |
DS4Windows_installer_x64_v3.2.13_try6.exe |
That is good news. I got the email notification about the other post and that .NET Desktop Runtime check is bundled in the main executable when targeting the .NET Runtime. That error is actually Microsoft's problem. Maybe a reboot would have been enough to work around that problem. Also, I uploaded more recent source files for the setup files |
Describe the bug
When running the installer, it shows the message .NET install was not found, even though .NET is installed
To Reproduce
Expected behavior
Installer finds .NET installation and proceeds as normal.
Screenshots and Logs
Registry editor shows .NET installed
Dotnet CLI info
Info
Also tried with .NET 6.0.20 and 7.0.9, no effect
Workaround
For those looking to install the app, just follow the instructions found in https://ds4-windows.com/get-started/
The text was updated successfully, but these errors were encountered: