From 33f4cbaf74a91a223d76591536615fd4c3356fc4 Mon Sep 17 00:00:00 2001
From: "Dr. Inzi" <158808246+DrInzi@users.noreply.github.com>
Date: Fri, 9 Feb 2024 10:52:03 +0100
Subject: [PATCH 01/11] [Exiled::API] Additions to Features.Player (#2435)

* [Exiled::API] Added AccountAge to Features.Player

* [Exiled::API] Additions to Features.Player

* Update Exiled.API.csproj

* Update Player.cs

* Update Exiled.API.csproj

* Update Player.cs

* Update Player.cs (reviews with yamato baguette)

* Update Player.cs

* Update Player.cs

* Update Player.cs

* Update Player.cs

* Update Player.cs

* Update Player.cs

* Update Player.cs

* Update Player.cs

* Merge branch 'IsScp096Target-IsScp173Observer' of https://github.com/DrInzi/EXILED into IsScp096Target-IsScp173Observer

---------

Co-authored-by: INZI <iosonomattia007@gmail.com>
Co-authored-by: Yamato <66829532+louis1706@users.noreply.github.com>
---
 Exiled.API/Features/Player.cs | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/Exiled.API/Features/Player.cs b/Exiled.API/Features/Player.cs
index 3c180239c5..d2dd65a465 100644
--- a/Exiled.API/Features/Player.cs
+++ b/Exiled.API/Features/Player.cs
@@ -1109,6 +1109,24 @@ public bool BadgeHidden
         /// </summary>
         public bool IsInventoryFull => Items.Count >= Inventory.MaxSlots;
 
+        /// <summary>
+        /// Gets a value indicating whether the player is a target of SCP-096.
+        /// </summary>
+        /// <remarks>
+        /// This property checks if the player is present in the list of targets maintained by SCP-096.
+        /// </remarks>
+        /// <returns>True if the player is a target of SCP-096; otherwise, false.</returns>
+        public bool IsScp096Target => Player.List.Any(x => x.Role is Roles.Scp096Role scp096Role && scp096Role.Targets.Contains(x));
+
+        /// <summary>
+        /// Gets a value indicating whether the player is an observer of SCP-173.
+        /// </summary>
+        /// <remarks>
+        /// This property checks if the player is present in the list of observers maintained by SCP-173.
+        /// </remarks>
+        /// <returns>True if the player is an observer of SCP-173; otherwise, false.</returns>
+        public bool IsScp173Observer => Player.List.Any(x => x.Role is Roles.Scp173Role scp173Role && scp173Role.ObservingPlayers.Contains(x));
+
         /// <summary>
         /// Gets a value indicating whether or not the player has agreed to microphone recording.
         /// </summary>

From a3fae80861d668213c2189d57793741c10cacbe5 Mon Sep 17 00:00:00 2001
From: Yamato <66829532+louis1706@users.noreply.github.com>
Date: Fri, 9 Feb 2024 10:53:06 +0100
Subject: [PATCH 02/11] Boup (#2440)

---
 Exiled.API/Extensions/DamageTypeExtensions.cs |  6 +----
 Exiled.CreditTags/CreditTags.cs               | 23 ++++++++-----------
 2 files changed, 10 insertions(+), 19 deletions(-)

diff --git a/Exiled.API/Extensions/DamageTypeExtensions.cs b/Exiled.API/Extensions/DamageTypeExtensions.cs
index 8d9985f966..3f58d449e3 100644
--- a/Exiled.API/Extensions/DamageTypeExtensions.cs
+++ b/Exiled.API/Extensions/DamageTypeExtensions.cs
@@ -117,11 +117,7 @@ public static class DamageTypeExtensions
         /// </summary>
         /// <param name="type">The damage type to be checked.</param>
         /// <returns>Returns whether or not the <see cref="DamageType"/> is caused by status effect.</returns>
-        public static bool IsStatusEffect(this DamageType type) => type switch
-        {
-            DamageType.Asphyxiation or DamageType.Poison or DamageType.Bleeding or DamageType.Scp207 or DamageType.Hypothermia or DamageType.Strangled => true,
-            _ => false,
-        };
+        public static bool IsStatusEffect(this DamageType type) => type is DamageType.Asphyxiation or DamageType.Poison or DamageType.Bleeding or DamageType.Scp207 or DamageType.Hypothermia or DamageType.Strangled;
 
         /// <summary>
         /// Gets the <see cref="DamageType"/> of an <see cref="DamageHandlerBase"/>s.
diff --git a/Exiled.CreditTags/CreditTags.cs b/Exiled.CreditTags/CreditTags.cs
index aecb1b758e..09a2a4f77e 100644
--- a/Exiled.CreditTags/CreditTags.cs
+++ b/Exiled.CreditTags/CreditTags.cs
@@ -134,22 +134,17 @@ void ShowRank(RankType rank)
                 {
                     switch (Config.Mode)
                     {
-                        case InfoSide.Badge:
-                            if (canReceiveCreditBadge)
-                                SetCreditBadge(player, value);
-
+                        case InfoSide.Badge when canReceiveCreditBadge:
+                            SetCreditBadge(player, value);
                             break;
-                        case InfoSide.CustomPlayerInfo:
-                            if (canReceiveCreditCustomInfo)
-                                SetCreditCustomInfo(player, value);
-
+                        case InfoSide.CustomPlayerInfo when canReceiveCreditCustomInfo:
+                            SetCreditCustomInfo(player, value);
                             break;
-                        case InfoSide.FirstAvailable:
-                            if (canReceiveCreditBadge)
-                                SetCreditBadge(player, value);
-                            else if (canReceiveCreditCustomInfo)
-                                SetCreditCustomInfo(player, value);
-
+                        case InfoSide.FirstAvailable when canReceiveCreditBadge:
+                            SetCreditBadge(player, value);
+                            break;
+                        case InfoSide.FirstAvailable when canReceiveCreditCustomInfo:
+                            SetCreditCustomInfo(player, value);
                             break;
                     }
                 }

From c27579b7b68c0674f88fd57ef3594f168c467dd8 Mon Sep 17 00:00:00 2001
From: Yamato <66829532+louis1706@users.noreply.github.com>
Date: Fri, 9 Feb 2024 10:53:17 +0100
Subject: [PATCH 03/11] EscapeScenario (#2439)

---
 Exiled.API/Enums/EscapeScenario.cs            | 23 +++++++++++++------
 .../EventArgs/Player/EscapingEventArgs.cs     |  2 +-
 2 files changed, 17 insertions(+), 8 deletions(-)

diff --git a/Exiled.API/Enums/EscapeScenario.cs b/Exiled.API/Enums/EscapeScenario.cs
index b02058ccdd..2c8f4f7223 100644
--- a/Exiled.API/Enums/EscapeScenario.cs
+++ b/Exiled.API/Enums/EscapeScenario.cs
@@ -7,39 +7,48 @@
 
 namespace Exiled.API.Enums
 {
+    using Exiled.API.Features.Core.Generic;
+
+    using static Escape;
+
     /// <summary>
     /// A set of different Escape Scenario Type.
     /// </summary>
-    public enum EscapeScenario
+    public sealed class EscapeScenario : EnumClass<EscapeScenarioType, EscapeScenario>
     {
         /// <summary>
         /// No Escape Scenario.
         /// </summary>
-        None,
+        public static readonly EscapeScenario None = new(EscapeScenarioType.None);
 
         /// <summary>
         /// ClassD Escape Scenario.
         /// </summary>
-        ClassD,
+        public static readonly EscapeScenario ClassD = new(EscapeScenarioType.ClassD);
 
         /// <summary>
         /// Cuffed ClassD Escape.
         /// </summary>
-        CuffedClassD,
+        public static readonly EscapeScenario CuffedClassD = new(EscapeScenarioType.CuffedClassD);
 
         /// <summary>
         /// Scientist Escape.
         /// </summary>
-        Scientist,
+        public static readonly EscapeScenario Scientist = new(EscapeScenarioType.Scientist);
 
         /// <summary>
         /// Cuffed Scientist Escape.
         /// </summary>
-        CuffedScientist,
+        public static readonly EscapeScenario CuffedScientist = new(EscapeScenarioType.CuffedScientist);
 
         /// <summary>
         /// Unspecified Escape.
         /// </summary>
-        CustomEscape,
+        public static readonly EscapeScenario CustomEscape = new((EscapeScenarioType)5);
+
+        private EscapeScenario(EscapeScenarioType value)
+            : base(value)
+        {
+        }
     }
 }
\ No newline at end of file
diff --git a/Exiled.Events/EventArgs/Player/EscapingEventArgs.cs b/Exiled.Events/EventArgs/Player/EscapingEventArgs.cs
index 109a744b12..f51eb1df75 100644
--- a/Exiled.Events/EventArgs/Player/EscapingEventArgs.cs
+++ b/Exiled.Events/EventArgs/Player/EscapingEventArgs.cs
@@ -39,7 +39,7 @@ public EscapingEventArgs(Player player, RoleTypeId newRole, EscapeScenario escap
             Player = player;
             NewRole = newRole;
             EscapeScenario = escapeScenario;
-            IsAllowed = escapeScenario is not EscapeScenario.CustomEscape;
+            IsAllowed = escapeScenario != EscapeScenario.CustomEscape;
         }
 
         /// <summary>

From c0c83969f12db43984526914df7d9ff610b6b40d Mon Sep 17 00:00:00 2001
From: Yamato <66829532+louis1706@users.noreply.github.com>
Date: Fri, 9 Feb 2024 10:53:41 +0100
Subject: [PATCH 04/11] TODO (#2438)

* TODO

* bool
---
 Exiled.API/Enums/EffectType.cs                |  2 +-
 Exiled.API/Features/Player.cs                 | 19 -------------
 Exiled.API/Features/Roles/Scp106Role.cs       |  8 +++---
 .../Player/AimingDownSightEventArgs.cs        |  9 ++-----
 .../Player/ChangingMoveStateEventArgs.cs      | 27 +++----------------
 .../Player/PreAuthenticatingEventArgs.cs      |  7 -----
 .../Scp0492/ConsumingCorpseEventArgs.cs       | 17 +++---------
 .../EventArgs/Scp173/BlinkingEventArgs.cs     |  3 +--
 Exiled.Events/Handlers/Player.cs              |  9 +++----
 .../Events/Player/ChangingMoveState.cs        |  5 +---
 .../Patches/Events/Player/DamagingWindow.cs   |  4 +--
 .../Events/Player/FirearmRequestReceived.cs   | 10 ++-----
 .../Patches/Events/Player/ThrownProjectile.cs |  2 +-
 .../Patches/Events/Scp0492/Consuming.cs       |  9 +++----
 Exiled.Events/Patches/Generic/RoomList.cs     |  1 +
 15 files changed, 30 insertions(+), 102 deletions(-)

diff --git a/Exiled.API/Enums/EffectType.cs b/Exiled.API/Enums/EffectType.cs
index 665f481632..690856b642 100644
--- a/Exiled.API/Enums/EffectType.cs
+++ b/Exiled.API/Enums/EffectType.cs
@@ -21,7 +21,7 @@ public enum EffectType
         /// <summary>
         /// This EffectType do not exist it's only use when not found or error.
         /// </summary>
-        None = -1, // TODO: remove = -1
+        None,
 
         /// <summary>
         /// The player isn't able to open their inventory or reload a weapon.
diff --git a/Exiled.API/Features/Player.cs b/Exiled.API/Features/Player.cs
index d2dd65a465..2ad3f57386 100644
--- a/Exiled.API/Features/Player.cs
+++ b/Exiled.API/Features/Player.cs
@@ -1517,16 +1517,6 @@ public static Player Get(string args)
         /// <returns>An <see cref="IEnumerable{Player}"/> representing the processed players.</returns>
         public static IEnumerable<Player> GetProcessedData(ArraySegment<string> args, int startIndex = 0) => GetProcessedData(args, startIndex, out string[] _);
 
-        /// <summary>
-        /// Adds a player's UserId to the list of reserved slots.
-        /// </summary>
-        /// <remarks>This method does not permanently give a user a reserved slot. The slot will be removed if the reserved slots are reloaded.</remarks>
-        /// <param name="userId">The UserId of the player to add.</param>
-        /// <returns><see langword="true"/> if the slot was successfully added, or <see langword="false"/> if the provided UserId already has a reserved slot.</returns>
-        /// <seealso cref="GiveReservedSlot()"/>
-        // TODO: Remove this method
-        public static bool AddReservedSlot(string userId) => ReservedSlot.Users.Add(userId);
-
         /// <summary>
         /// Adds a player's UserId to the list of reserved slots.
         /// </summary>
@@ -1579,15 +1569,6 @@ public static bool AddToWhitelist(string userId, bool isPermanent)
         /// </summary>
         public static void ReloadWhitelist() => WhiteList.Reload();
 
-        /// <summary>
-        /// Adds the player's UserId to the list of reserved slots.
-        /// </summary>
-        /// <remarks>This method does not permanently give a user a reserved slot. The slot will be removed if the reserved slots are reloaded.</remarks>
-        /// <returns><see langword="true"/> if the slot was successfully added, or <see langword="false"/> if the player already has a reserved slot.</returns>
-        /// <seealso cref="AddReservedSlot(string)"/>
-        // TODO: Remove this method
-        public bool GiveReservedSlot() => AddReservedSlot(UserId);
-
         /// <summary>
         /// Adds a player's UserId to the list of reserved slots.
         /// </summary>
diff --git a/Exiled.API/Features/Roles/Scp106Role.cs b/Exiled.API/Features/Roles/Scp106Role.cs
index 79ce548735..e4ed9e4a03 100644
--- a/Exiled.API/Features/Roles/Scp106Role.cs
+++ b/Exiled.API/Features/Roles/Scp106Role.cs
@@ -297,15 +297,16 @@ public bool UsePortal(Vector3 position, float cost = 0f)
         /// Send a player to the pocket dimension.
         /// </summary>
         /// <param name="player">The <see cref="Player"/>to send.</param>
-        public void CapturePlayer(Player player) // Convert to bool.
+        /// <returns>If the player has been capture in PocketDimension.</returns>
+        public bool CapturePlayer(Player player)
         {
             if (player is null)
-                return;
+                return false;
             Attack._targetHub = player.ReferenceHub;
             DamageHandlerBase handler = new ScpDamageHandler(Attack.Owner, AttackDamage, DeathTranslations.PocketDecay);
 
             if (!Attack._targetHub.playerStats.DealDamage(handler))
-                return;
+                return false;
 
             Attack.SendCooldown(Attack._hitCooldown);
             Vigor += VigorCaptureReward;
@@ -313,6 +314,7 @@ public void CapturePlayer(Player player) // Convert to bool.
             Hitmarker.SendHitmarkerDirectly(Attack.Owner, 1f);
 
             player.EnableEffect(EffectType.PocketCorroding);
+            return true;
         }
 
         /// <summary>
diff --git a/Exiled.Events/EventArgs/Player/AimingDownSightEventArgs.cs b/Exiled.Events/EventArgs/Player/AimingDownSightEventArgs.cs
index eebbae5a3a..9370ba42b5 100644
--- a/Exiled.Events/EventArgs/Player/AimingDownSightEventArgs.cs
+++ b/Exiled.Events/EventArgs/Player/AimingDownSightEventArgs.cs
@@ -15,7 +15,6 @@ namespace Exiled.Events.EventArgs.Player
     /// <summary>
     /// Contains all information when a player aims.
     /// </summary>
-    // TODO: remove stupid AdsIn/AdsOut propetry, and let exists only one
     public class AimingDownSightEventArgs : IPlayerEvent, IFirearmEvent
     {
         /// <summary>
@@ -30,15 +29,11 @@ public class AimingDownSightEventArgs : IPlayerEvent, IFirearmEvent
         /// <param name="adsIn">
         /// <inheritdoc cref="AdsIn" />
         /// </param>
-        /// <param name="adsOut">
-        /// <inheritdoc cref="AdsOut" />
-        /// </param>
-        public AimingDownSightEventArgs(Player player, Firearm firearm, bool adsIn, bool adsOut)
+        public AimingDownSightEventArgs(Player player, Firearm firearm, bool adsIn)
         {
             Firearm = firearm;
             Player = player;
             AdsIn = adsIn;
-            AdsOut = adsOut;
         }
 
         /// <summary>
@@ -49,7 +44,7 @@ public AimingDownSightEventArgs(Player player, Firearm firearm, bool adsIn, bool
         /// <summary>
         /// Gets a value indicating whether or not the player is aiming down sight out.
         /// </summary>
-        public bool AdsOut { get; }
+        public bool AdsOut => !AdsIn;
 
         /// <summary>
         /// Gets the <see cref="API.Features.Items.Firearm" /> used to trigger the aim action.
diff --git a/Exiled.Events/EventArgs/Player/ChangingMoveStateEventArgs.cs b/Exiled.Events/EventArgs/Player/ChangingMoveStateEventArgs.cs
index 1c55aa6aaf..dc22fa26e9 100644
--- a/Exiled.Events/EventArgs/Player/ChangingMoveStateEventArgs.cs
+++ b/Exiled.Events/EventArgs/Player/ChangingMoveStateEventArgs.cs
@@ -18,7 +18,7 @@ namespace Exiled.Events.EventArgs.Player
     /// <summary>
     /// Contains all information before changing movement state.
     /// </summary>
-    public class ChangingMoveStateEventArgs : IPlayerEvent, IDeniableEvent
+    public class ChangingMoveStateEventArgs : IPlayerEvent
     {
         /// <summary>
         /// Initializes a new instance of the <see cref="ChangingMoveStateEventArgs" /> class.
@@ -32,16 +32,10 @@ public class ChangingMoveStateEventArgs : IPlayerEvent, IDeniableEvent
         /// <param name="newState">
         /// <inheritdoc cref="NewState" />
         /// </param>
-        /// <param name="isAllowed">
-        /// <inheritdoc cref="IsAllowed" />
-        /// </param>
-        public ChangingMoveStateEventArgs(Player player, PlayerMovementState oldState, PlayerMovementState newState, bool isAllowed = true)
+        public ChangingMoveStateEventArgs(Player player, PlayerMovementState oldState, PlayerMovementState newState)
         {
             Player = player;
             OldState = oldState;
-#pragma warning disable CS0618
-            NewState = newState;
-#pragma warning restore CS0618
         }
 
         /// <summary>
@@ -55,21 +49,8 @@ public ChangingMoveStateEventArgs(Player player, PlayerMovementState oldState, P
         public PlayerMovementState OldState { get; }
 
         /// <summary>
-        /// Gets or sets the new state.
-        /// </summary>
-        // TODO: remove setter
-        public PlayerMovementState NewState
-        {
-            get;
-            [Obsolete("Setter was removed due to desync problems.")]
-            set;
-        }
-
-        /// <summary>
-        /// Gets or sets a value indicating whether the player can change the movement state.
+        /// Gets the new state.
         /// </summary>
-        // TODO: remove
-        [Obsolete("Property was removed due to desync problems.")]
-        public bool IsAllowed { get; set; } = true;
+        public PlayerMovementState NewState { get; }
     }
 }
\ No newline at end of file
diff --git a/Exiled.Events/EventArgs/Player/PreAuthenticatingEventArgs.cs b/Exiled.Events/EventArgs/Player/PreAuthenticatingEventArgs.cs
index 0b10296f2a..da0845899b 100644
--- a/Exiled.Events/EventArgs/Player/PreAuthenticatingEventArgs.cs
+++ b/Exiled.Events/EventArgs/Player/PreAuthenticatingEventArgs.cs
@@ -15,13 +15,6 @@ namespace Exiled.Events.EventArgs.Player
 
     using PluginAPI.Events;
 
-#pragma warning disable SA1600 //TODO:
-#pragma warning disable SA1309
-#pragma warning disable SA1623
-#pragma warning disable SA1201
-#pragma warning disable SA1611
-#pragma warning disable CS1591
-
     /// <summary>
     /// Contains all information before pre-authenticating a player.
     /// </summary>
diff --git a/Exiled.Events/EventArgs/Scp0492/ConsumingCorpseEventArgs.cs b/Exiled.Events/EventArgs/Scp0492/ConsumingCorpseEventArgs.cs
index d398e147a5..dd136a91dd 100644
--- a/Exiled.Events/EventArgs/Scp0492/ConsumingCorpseEventArgs.cs
+++ b/Exiled.Events/EventArgs/Scp0492/ConsumingCorpseEventArgs.cs
@@ -24,16 +24,14 @@ public class ConsumingCorpseEventArgs : IScp0492Event, IRagdollEvent, IDeniableE
         /// </summary>
         /// <param name="player"> <inheritdoc cref="Player"/></param>
         /// <param name="ragDoll"> <inheritdoc cref="Ragdoll"/> </param>
-        /// <param name="error"> <inheritdoc cref="ErrorCode"/> </param>
         /// <param name="isAllowed"> <inheritdoc cref="IsAllowed"/> </param>
         /// <remarks> See <see cref="ZombieConsumeAbility.ConsumedRagdolls"/> for all ragdolls consumed.</remarks>
-        // TODO: remove isAllowed argument
-        public ConsumingCorpseEventArgs(ReferenceHub player, BasicRagdoll ragDoll, ZombieConsumeAbility.ConsumeError error, bool isAllowed = true)
+        public ConsumingCorpseEventArgs(ReferenceHub player, BasicRagdoll ragDoll, bool isAllowed = true)
         {
             Player = Player.Get(player);
             Scp0492 = Player.Role.As<Scp0492Role>();
             Ragdoll = Ragdoll.Get(ragDoll);
-            ErrorCode = error;
+            IsAllowed = isAllowed;
         }
 
         /// <summary>
@@ -49,18 +47,9 @@ public ConsumingCorpseEventArgs(ReferenceHub player, BasicRagdoll ragDoll, Zombi
         /// </summary>
         public Ragdoll Ragdoll { get; }
 
-        /// <summary>
-        /// Gets or sets error code to send back to client.
-        /// </summary>
-        public ZombieConsumeAbility.ConsumeError ErrorCode { get; set; }
-
         /// <summary>
         /// Gets or sets a value indicating whether 049-2 can consume a corpse.
         /// </summary>
-        public bool IsAllowed
-        {
-            get => ErrorCode == ZombieConsumeAbility.ConsumeError.None;
-            set => ErrorCode = value ? ZombieConsumeAbility.ConsumeError.None : ZombieConsumeAbility.ConsumeError.TargetNotValid;
-        }
+        public bool IsAllowed { get; set; }
     }
 }
\ No newline at end of file
diff --git a/Exiled.Events/EventArgs/Scp173/BlinkingEventArgs.cs b/Exiled.Events/EventArgs/Scp173/BlinkingEventArgs.cs
index 5ef166038d..f46635930b 100644
--- a/Exiled.Events/EventArgs/Scp173/BlinkingEventArgs.cs
+++ b/Exiled.Events/EventArgs/Scp173/BlinkingEventArgs.cs
@@ -58,8 +58,7 @@ public BlinkingEventArgs(Player player, List<Player> targets, Vector3 blinkPos)
         /// <summary>
         /// Gets a <see cref="IEnumerable{T}" /> of players who have triggered SCP-173.
         /// </summary>
-        // TODO: convert to ReadOnlyCollection
-        public List<Player> Targets { get; }
+        public IReadOnlyList<Player> Targets { get; }
 
         /// <summary>
         /// Gets or sets a value indicating whether or not the player is allowed to blink.
diff --git a/Exiled.Events/Handlers/Player.cs b/Exiled.Events/Handlers/Player.cs
index bd66fa0798..c949dd92ca 100644
--- a/Exiled.Events/Handlers/Player.cs
+++ b/Exiled.Events/Handlers/Player.cs
@@ -469,8 +469,8 @@ public class Player
 
         /// <summary>
         /// Invoked before a <see cref="API.Features.Player"/> damage a Window.
-        /// </summary> // TODO: DamagingWindow instead of PlayerDamageWindow
-        public static Event<DamagingWindowEventArgs> PlayerDamageWindow { get; set; } = new();
+        /// </summary>
+        public static Event<DamagingWindowEventArgs> DamagingWindow { get; set; } = new();
 
         /// <summary>
         /// Invoked before a <see cref="API.Features.Player"/> damage a Door.
@@ -652,8 +652,7 @@ public class Player
         /// Called before throwing a grenade.
         /// </summary>
         /// <param name="ev">The <see cref="ThrownProjectileEventArgs"/> instance.</param>
-        // TODO: rename that to OnThrownProjectile
-        public static void OnThrowingProjectile(ThrownProjectileEventArgs ev) => ThrownProjectile.InvokeSafely(ev);
+        public static void OnThrownProjectile(ThrownProjectileEventArgs ev) => ThrownProjectile.InvokeSafely(ev);
 
         /// <summary>
         /// Called before receving a throwing request.
@@ -1001,7 +1000,7 @@ public static void OnItemRemoved(ReferenceHub referenceHub, InventorySystem.Item
         /// Called before a <see cref="API.Features.Player"/> damage a window.
         /// </summary>
         /// <param name="ev">The <see cref="DamagingWindowEventArgs"/> instance. </param>
-        public static void OnPlayerDamageWindow(DamagingWindowEventArgs ev) => PlayerDamageWindow.InvokeSafely(ev);
+        public static void OnPlayerDamageWindow(DamagingWindowEventArgs ev) => DamagingWindow.InvokeSafely(ev);
 
         /// <summary>
         /// Called before a <see cref="API.Features.Player"/> damage a window.
diff --git a/Exiled.Events/Patches/Events/Player/ChangingMoveState.cs b/Exiled.Events/Patches/Events/Player/ChangingMoveState.cs
index 1c11ad5332..090db2c42a 100644
--- a/Exiled.Events/Patches/Events/Player/ChangingMoveState.cs
+++ b/Exiled.Events/Patches/Events/Player/ChangingMoveState.cs
@@ -58,10 +58,7 @@ private static IEnumerable<CodeInstruction> Transpiler(IEnumerable<CodeInstructi
                     // value
                     new(OpCodes.Ldarg_1),
 
-                    // true
-                    new(OpCodes.Ldc_I4_1),
-
-                    // ChangingMoveStateEventArgs ev = new(Player, PlayerMovementState, PlayerMovementState, bool)
+                    // ChangingMoveStateEventArgs ev = new(Player, PlayerMovementState, PlayerMovementState)
                     new(OpCodes.Newobj, GetDeclaredConstructors(typeof(ChangingMoveStateEventArgs))[0]),
                     new(OpCodes.Dup, ev.LocalIndex),
                     new(OpCodes.Stloc_S, ev.LocalIndex),
diff --git a/Exiled.Events/Patches/Events/Player/DamagingWindow.cs b/Exiled.Events/Patches/Events/Player/DamagingWindow.cs
index ea5a3d457b..2bce4efdfa 100644
--- a/Exiled.Events/Patches/Events/Player/DamagingWindow.cs
+++ b/Exiled.Events/Patches/Events/Player/DamagingWindow.cs
@@ -25,9 +25,9 @@ namespace Exiled.Events.Patches.Events.Player
 
     /// <summary>
     /// Patch the <see cref="BreakableWindow.Damage(float, PlayerStatsSystem.DamageHandlerBase, Vector3)" />.
-    /// Adds the <see cref="Player.PlayerDamageWindow" /> event.
+    /// Adds the <see cref="Player.DamagingWindow" /> event.
     /// </summary>
-    [EventPatch(typeof(Player), nameof(Player.PlayerDamageWindow))]
+    [EventPatch(typeof(Player), nameof(Player.DamagingWindow))]
     [HarmonyPatch(typeof(BreakableWindow), nameof(BreakableWindow.Damage))]
     internal static class DamagingWindow
     {
diff --git a/Exiled.Events/Patches/Events/Player/FirearmRequestReceived.cs b/Exiled.Events/Patches/Events/Player/FirearmRequestReceived.cs
index 5a6b90e439..1a7a46d8b5 100644
--- a/Exiled.Events/Patches/Events/Player/FirearmRequestReceived.cs
+++ b/Exiled.Events/Patches/Events/Player/FirearmRequestReceived.cs
@@ -183,10 +183,7 @@ private static IEnumerable<CodeInstruction> Transpiler(IEnumerable<CodeInstructi
                     // true (adsIn)
                     new(OpCodes.Ldc_I4_1),
 
-                    // false (adsOut)
-                    new(OpCodes.Ldc_I4_0),
-
-                    // AimingDownSightEventArgs ev = new(Player, firearm, bool, bool)
+                    // AimingDownSightEventArgs ev = new(Player, firearm, bool)
                     new(OpCodes.Newobj, GetDeclaredConstructors(typeof(AimingDownSightEventArgs))[0]),
 
                     // Player.OnAimingDownSight(ev)
@@ -210,10 +207,7 @@ private static IEnumerable<CodeInstruction> Transpiler(IEnumerable<CodeInstructi
                     // false (adsIn)
                     new(OpCodes.Ldc_I4_0),
 
-                    // true (adsOut)
-                    new(OpCodes.Ldc_I4_1),
-
-                    // AimingDownSightEventArgs ev = new(Player, firearm, bool, bool)
+                    // AimingDownSightEventArgs ev = new(Player, firearm, bool)
                     new(OpCodes.Newobj, GetDeclaredConstructors(typeof(AimingDownSightEventArgs))[0]),
 
                     // Player.OnAimingDownSight(ev)
diff --git a/Exiled.Events/Patches/Events/Player/ThrownProjectile.cs b/Exiled.Events/Patches/Events/Player/ThrownProjectile.cs
index d54ff06ba6..301f6d3b78 100644
--- a/Exiled.Events/Patches/Events/Player/ThrownProjectile.cs
+++ b/Exiled.Events/Patches/Events/Player/ThrownProjectile.cs
@@ -58,7 +58,7 @@ private static IEnumerable<CodeInstruction> Transpiler(IEnumerable<CodeInstructi
                 new(OpCodes.Newobj, GetDeclaredConstructors(typeof(ThrownProjectileEventArgs))[0]),
 
                 // Handlers.Player.OnThrownProjectile(ev);
-                new(OpCodes.Call, Method(typeof(Handlers.Player), nameof(Handlers.Player.OnThrowingProjectile))),
+                new(OpCodes.Call, Method(typeof(Handlers.Player), nameof(Handlers.Player.OnThrownProjectile))),
             });
 
             newInstructions[newInstructions.Count - 1].labels.Add(returnLabel);
diff --git a/Exiled.Events/Patches/Events/Scp0492/Consuming.cs b/Exiled.Events/Patches/Events/Scp0492/Consuming.cs
index fcc91617a3..e8532b4b57 100644
--- a/Exiled.Events/Patches/Events/Scp0492/Consuming.cs
+++ b/Exiled.Events/Patches/Events/Scp0492/Consuming.cs
@@ -44,21 +44,18 @@ private static IEnumerable<CodeInstruction> Transpiler(IEnumerable<CodeInstructi
                 // radgoll
                 new(OpCodes.Ldarg_1),
 
-                // ConsumeError.None
-                new(OpCodes.Ldc_I4_0),
-
                 // true
                 new(OpCodes.Ldc_I4_1),
 
-                // ConsumingCorpseEventArgs ev = new(this.Owner, this.Ragdoll, ConsumeError.None, true)
+                // ConsumingCorpseEventArgs ev = new(this.Owner, this.Ragdoll, true)
                 new(OpCodes.Newobj, GetDeclaredConstructors(typeof(ConsumingCorpseEventArgs))[0]),
                 new(OpCodes.Dup),
 
                 // Handlers.Scp0492.OnConsumingCorpse(ev)
                 new(OpCodes.Call, Method(typeof(Handlers.Scp0492), nameof(Handlers.Scp0492.OnConsumingCorpse))),
 
-                // return new code
-                new(OpCodes.Callvirt, PropertyGetter(typeof(ConsumingCorpseEventArgs), nameof(ConsumingCorpseEventArgs.ErrorCode))),
+                // return ev.IsAllowed
+                new(OpCodes.Callvirt, PropertyGetter(typeof(ConsumingCorpseEventArgs), nameof(ConsumingCorpseEventArgs.IsAllowed))),
                 new(OpCodes.Ret),
             });
 
diff --git a/Exiled.Events/Patches/Generic/RoomList.cs b/Exiled.Events/Patches/Generic/RoomList.cs
index 934452bd7e..0b8b9632cd 100644
--- a/Exiled.Events/Patches/Generic/RoomList.cs
+++ b/Exiled.Events/Patches/Generic/RoomList.cs
@@ -45,6 +45,7 @@ private static IEnumerable<CodeInstruction> Transpiler(IEnumerable<CodeInstructi
                     new CodeInstruction(OpCodes.Ldarg_0).MoveLabelsFrom(newInstructions[index]),
                     new(OpCodes.Callvirt, PropertyGetter(typeof(Component), nameof(Component.gameObject))),
                     new(OpCodes.Newobj, GetDeclaredConstructors(typeof(Room))[0]),
+                    new(OpCodes.Pop),
                 });
 
             for (int z = 0; z < newInstructions.Count; z++)

From 670cf1de068f2674d71d1d2b5f44ef84ee68d96a Mon Sep 17 00:00:00 2001
From: Yamato <66829532+louis1706@users.noreply.github.com>
Date: Fri, 9 Feb 2024 10:54:15 +0100
Subject: [PATCH 05/11] SpawnReason (#2441)

* SpawnReason

- SpawnReason.ForceClass => spawnReason.RemoteAdmin
Add SpawnReason.ForceClass

* Fix
---
 Exiled.API/Enums/SpawnReason.cs   | 35 +++++++++++++++++++++----------
 Exiled.API/Features/Roles/Role.cs |  8 +++----
 2 files changed, 28 insertions(+), 15 deletions(-)

diff --git a/Exiled.API/Enums/SpawnReason.cs b/Exiled.API/Enums/SpawnReason.cs
index d5ab04e202..c7c9b6cb0e 100644
--- a/Exiled.API/Enums/SpawnReason.cs
+++ b/Exiled.API/Enums/SpawnReason.cs
@@ -7,54 +7,67 @@
 
 namespace Exiled.API.Enums
 {
+    using Exiled.API.Features.Core.Generic;
+    using PlayerRoles;
+
     /// <summary>
     /// Possible spawn reasons.
     /// </summary>
-    public enum SpawnReason : byte // TOTO: Remove this file and use Basegame
+    public sealed class SpawnReason : EnumClass<RoleChangeReason, SpawnReason>
     {
         /// <summary>
         /// No reason specified.
         /// </summary>
-        None,
+        public static readonly SpawnReason None = new(RoleChangeReason.None);
 
         /// <summary>
         /// The round has just started.
         /// </summary>
-        RoundStart,
+        public static readonly SpawnReason RoundStart = new(RoleChangeReason.RoundStart);
 
         /// <summary>
         /// The player joined and the round recently started.
         /// </summary>
-        LateJoin,
+        public static readonly SpawnReason LateJoin = new(RoleChangeReason.LateJoin);
 
         /// <summary>
         /// The player was dead and is respawning.
         /// </summary>
-        Respawn,
+        public static readonly SpawnReason Respawn = new(RoleChangeReason.Respawn);
 
         /// <summary>
         /// The player has died.
         /// </summary>
-        Died,
+        public static readonly SpawnReason Died = new(RoleChangeReason.Died);
 
         /// <summary>
         /// The player has escaped.
         /// </summary>
-        Escaped,
+        public static readonly SpawnReason Escaped = new(RoleChangeReason.Escaped);
 
         /// <summary>
         /// The player was revived by SCP-049.
         /// </summary>
-        Revived,
+        public static readonly SpawnReason Revived = new(RoleChangeReason.Revived);
 
         /// <summary>
-        /// The player's role was changed by an admin command or plugin.
+        /// The player's role was changed by an admin command.
         /// </summary>
-        ForceClass,
+        public static readonly SpawnReason RemoteAdmin = new(RoleChangeReason.RemoteAdmin);
 
         /// <summary>
         /// The user will be destroyed.
         /// </summary>
-        Destroyed,
+        public static readonly SpawnReason Destroyed = new(RoleChangeReason.Destroyed);
+
+        /// <summary>
+        /// The player's role was changed by an exiled plugin.
+        /// </summary>
+        public static readonly SpawnReason ForceClass = new(RoleChangeReason.RemoteAdmin);
+
+        private SpawnReason(RoleChangeReason value)
+            : base(value)
+        {
+        }
     }
 }
\ No newline at end of file
diff --git a/Exiled.API/Features/Roles/Role.cs b/Exiled.API/Features/Roles/Role.cs
index a7d38bdabc..8900b2ad81 100644
--- a/Exiled.API/Features/Roles/Role.cs
+++ b/Exiled.API/Features/Roles/Role.cs
@@ -229,14 +229,14 @@ public static RoleTypeId Random(bool includeNonPlayableRoles = false, IEnumerabl
         /// </summary>
         /// <param name="newRole">The new <see cref="RoleTypeId"/> to be set.</param>
         /// <param name="reason">The <see cref="Enums.SpawnReason"/> defining why the player's role was changed.</param>
-        public virtual void Set(RoleTypeId newRole, SpawnReason reason = Enums.SpawnReason.ForceClass) => Set(newRole, reason, RoleSpawnFlags.All);
+        public virtual void Set(RoleTypeId newRole, SpawnReason reason = null) => Set(newRole, reason ?? Enums.SpawnReason.ForceClass, RoleSpawnFlags.All);
 
-        /// <summary>
+        /// <summary>S
         /// Sets the player's <see cref="RoleTypeId"/>.
         /// </summary>
         /// <param name="newRole">The new <see cref="RoleTypeId"/> to be set.</param>
         /// <param name="spawnFlags">The <see cref="RoleSpawnFlags"/> defining player spawn logic.</param>
-        public virtual void Set(RoleTypeId newRole, RoleSpawnFlags spawnFlags) => Owner.RoleManager.ServerSetRole(newRole, (RoleChangeReason)Enums.SpawnReason.ForceClass, spawnFlags);
+        public virtual void Set(RoleTypeId newRole, RoleSpawnFlags spawnFlags) => Owner.RoleManager.ServerSetRole(newRole, Enums.SpawnReason.ForceClass, spawnFlags);
 
         /// <summary>
         /// Sets the player's <see cref="RoleTypeId"/>.
@@ -245,7 +245,7 @@ public static RoleTypeId Random(bool includeNonPlayableRoles = false, IEnumerabl
         /// <param name="reason">The <see cref="Enums.SpawnReason"/> defining why the player's role was changed.</param>
         /// <param name="spawnFlags">The <see cref="RoleSpawnFlags"/> defining player spawn logic.</param>
         public virtual void Set(RoleTypeId newRole, SpawnReason reason, RoleSpawnFlags spawnFlags) =>
-            Owner.RoleManager.ServerSetRole(newRole, (RoleChangeReason)reason, spawnFlags);
+            Owner.RoleManager.ServerSetRole(newRole, reason, spawnFlags);
 
         /// <summary>
         /// Creates a role from <see cref="RoleTypeId"/> and <see cref="Player"/>.

From 73ae1f3b88fb516a77d1034683498babc2d99bc3 Mon Sep 17 00:00:00 2001
From: Yamato <louismonneyron5@yahoo.com>
Date: Fri, 9 Feb 2024 12:35:56 +0100
Subject: [PATCH 06/11] Fix EscapingEvent

---
 Exiled.Events/EventArgs/Player/EscapingEventArgs.cs | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/Exiled.Events/EventArgs/Player/EscapingEventArgs.cs b/Exiled.Events/EventArgs/Player/EscapingEventArgs.cs
index f51eb1df75..b7ae474745 100644
--- a/Exiled.Events/EventArgs/Player/EscapingEventArgs.cs
+++ b/Exiled.Events/EventArgs/Player/EscapingEventArgs.cs
@@ -17,6 +17,8 @@ namespace Exiled.Events.EventArgs.Player
 
     using Respawning;
 
+    using static Escape;
+
     /// <summary>
     /// Contains all information before a player escapes.
     /// </summary>
@@ -34,11 +36,11 @@ public class EscapingEventArgs : IPlayerEvent, IDeniableEvent
         /// <param name="escapeScenario">
         /// <inheritdoc cref="EscapeScenario" />
         /// </param>
-        public EscapingEventArgs(Player player, RoleTypeId newRole, EscapeScenario escapeScenario)
+        public EscapingEventArgs(Player player, RoleTypeId newRole, EscapeScenarioType escapeScenario)
         {
             Player = player;
             NewRole = newRole;
-            EscapeScenario = escapeScenario;
+            EscapeScenario = (EscapeScenario)escapeScenario;
             IsAllowed = escapeScenario != EscapeScenario.CustomEscape;
         }
 
@@ -57,7 +59,7 @@ public EscapingEventArgs(Player player, RoleTypeId newRole, EscapeScenario escap
         /// <param name="respawnTickets">
         /// <inheritdoc cref="RespawnTickets"/>
         /// </param>
-        public EscapingEventArgs(Player player, RoleTypeId newRole, EscapeScenario escapeScenario, KeyValuePair<SpawnableTeamType, float> respawnTickets)
+        public EscapingEventArgs(Player player, RoleTypeId newRole, EscapeScenarioType escapeScenario, KeyValuePair<SpawnableTeamType, float> respawnTickets)
             : this(player, newRole, escapeScenario)
         {
             RespawnTickets = respawnTickets;
@@ -81,7 +83,7 @@ public EscapingEventArgs(Player player, RoleTypeId newRole, EscapeScenario escap
         /// <param name="ticketsToGrant">
         /// A <see langword="float"/> that <see cref="RespawnTickets"/> will be initialized with.
         /// </param>
-        public EscapingEventArgs(Player player, RoleTypeId newRole, EscapeScenario escapeScenario, SpawnableTeamType teamToGrantTickets, float ticketsToGrant)
+        public EscapingEventArgs(Player player, RoleTypeId newRole, EscapeScenarioType escapeScenario, SpawnableTeamType teamToGrantTickets, float ticketsToGrant)
             : this(player, newRole, escapeScenario)
         {
             if (teamToGrantTickets != SpawnableTeamType.None)

From c2d9035baf4f5fd5134ddb248a17b71570f1a797 Mon Sep 17 00:00:00 2001
From: Yamato <louismonneyron5@yahoo.com>
Date: Fri, 9 Feb 2024 13:05:00 +0100
Subject: [PATCH 07/11] Yamato Stupidity fix

---
 Exiled.API/Enums/SpawnReason.cs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Exiled.API/Enums/SpawnReason.cs b/Exiled.API/Enums/SpawnReason.cs
index c7c9b6cb0e..2ea15f84a2 100644
--- a/Exiled.API/Enums/SpawnReason.cs
+++ b/Exiled.API/Enums/SpawnReason.cs
@@ -63,7 +63,7 @@ public sealed class SpawnReason : EnumClass<RoleChangeReason, SpawnReason>
         /// <summary>
         /// The player's role was changed by an exiled plugin.
         /// </summary>
-        public static readonly SpawnReason ForceClass = new(RoleChangeReason.RemoteAdmin);
+        public static readonly SpawnReason ForceClass = new((RoleChangeReason)9);
 
         private SpawnReason(RoleChangeReason value)
             : base(value)

From c8dac35ac4c2a127429823d8eacaca54b70ea52a Mon Sep 17 00:00:00 2001
From: Yamato <louismonneyron5@yahoo.com>
Date: Fri, 9 Feb 2024 13:07:44 +0100
Subject: [PATCH 08/11] i miss this

---
 Exiled.Events/Patches/Events/Player/ChangingRoleAndSpawned.cs | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/Exiled.Events/Patches/Events/Player/ChangingRoleAndSpawned.cs b/Exiled.Events/Patches/Events/Player/ChangingRoleAndSpawned.cs
index c4e52dec3d..92ba68a943 100644
--- a/Exiled.Events/Patches/Events/Player/ChangingRoleAndSpawned.cs
+++ b/Exiled.Events/Patches/Events/Player/ChangingRoleAndSpawned.cs
@@ -16,6 +16,7 @@ namespace Exiled.Events.Patches.Events.Player
     using API.Features.Core.Generic.Pools;
 
     using API.Features.Roles;
+    using Exiled.API.Enums;
     using Exiled.Events.EventArgs.Player;
 
     using HarmonyLib;
@@ -111,8 +112,9 @@ private static IEnumerable<CodeInstruction> Transpiler(IEnumerable<CodeInstructi
                     new(OpCodes.Callvirt, PropertyGetter(typeof(ChangingRoleEventArgs), nameof(ChangingRoleEventArgs.NewRole))),
                     new(OpCodes.Starg_S, 1),
 
-                    // reason = changingRoleEventArgs.Reason
+                    // reason = changingRoleEventArgs.Reason.Value
                     new(OpCodes.Callvirt, PropertyGetter(typeof(ChangingRoleEventArgs), nameof(ChangingRoleEventArgs.Reason))),
+                    new(OpCodes.Callvirt, PropertyGetter(typeof(SpawnReason), nameof(SpawnReason.Value))),
                     new(OpCodes.Starg_S, 2),
 
                     // spawnFlags = changingRoleEventArgs.SpawnFlags

From 9d9e6366c0a955a4c363d72a799ad18a526ef19c Mon Sep 17 00:00:00 2001
From: VALERA771 <72030575+VALERA771@users.noreply.github.com>
Date: Sat, 10 Feb 2024 03:06:54 +0300
Subject: [PATCH 09/11] new ext (#2446)

---
 Exiled.API/Extensions/MirrorExtensions.cs | 26 ++++++++++++++++++-----
 Exiled.API/Features/Roles/Scp3114Role.cs  | 12 +++++++++++
 2 files changed, 33 insertions(+), 5 deletions(-)

diff --git a/Exiled.API/Extensions/MirrorExtensions.cs b/Exiled.API/Extensions/MirrorExtensions.cs
index 7baf72eb64..79ec9e3a4c 100644
--- a/Exiled.API/Extensions/MirrorExtensions.cs
+++ b/Exiled.API/Extensions/MirrorExtensions.cs
@@ -17,18 +17,14 @@ namespace Exiled.API.Extensions
 
     using Features;
     using Features.Core.Generic.Pools;
-
     using InventorySystem.Items.Firearms;
-
     using Mirror;
-
     using PlayerRoles;
     using PlayerRoles.FirstPersonControl;
     using PlayerRoles.PlayableScps.Scp049.Zombies;
+    using PlayerRoles.Subroutines;
     using RelativePositioning;
-
     using Respawning;
-
     using UnityEngine;
 
     /// <summary>
@@ -449,6 +445,26 @@ public static void EditNetworkObject(NetworkIdentity identity, Action<NetworkIde
             }
         }
 
+        /// <summary>
+        /// Sends a <see cref="SubroutineMessage"/>.
+        /// </summary>
+        /// <param name="subroutineBase">Base <see cref="SubroutineBase"/> instance.</param>
+        /// <param name="applyingChanges">Action that will apply needed changes to a <paramref name="subroutineBase"/>.</param>
+        /// <param name="toAll">Should message be sent to everybody or to <see cref="SubroutineBase.Role"/> only.</param>
+        /// <typeparam name="T">A type of <see cref="SubroutineBase"/>.</typeparam>
+        public static void SendRpc<T>(this T subroutineBase, Action<T> applyingChanges, bool toAll = true)
+            where T : SubroutineBase
+        {
+            applyingChanges(subroutineBase);
+
+            SubroutineMessage msg = new(subroutineBase, true);
+
+            if (toAll)
+                NetworkServer.SendToAll(msg);
+            else
+                subroutineBase.Role._lastOwner.connectionToClient.Send(msg);
+        }
+
         // Get components index in identity.(private)
         private static int GetComponentIndex(NetworkIdentity identity, Type type)
         {
diff --git a/Exiled.API/Features/Roles/Scp3114Role.cs b/Exiled.API/Features/Roles/Scp3114Role.cs
index 31ef601c1c..3814ad3081 100644
--- a/Exiled.API/Features/Roles/Scp3114Role.cs
+++ b/Exiled.API/Features/Roles/Scp3114Role.cs
@@ -9,6 +9,8 @@ namespace Exiled.API.Features.Roles
 {
     using System.Collections.Generic;
 
+    using Exiled.API.Enums;
+    using Exiled.API.Extensions;
     using PlayerRoles;
     using PlayerRoles.PlayableScps;
     using PlayerRoles.PlayableScps.HumeShield;
@@ -235,5 +237,15 @@ public void PlaySound(Scp3114VoiceLines.VoiceLinesName voiceLine = Scp3114VoiceL
         /// <param name="alreadySpawned">The List of Roles already spawned.</param>
         /// <returns>The Spawn Chance.</returns>
         public float GetSpawnChance(List<RoleTypeId> alreadySpawned) => Base is ISpawnableScp spawnableScp ? spawnableScp.GetSpawnChance(alreadySpawned) : 0;
+
+        /// <summary>
+        /// Stops dancing.
+        /// </summary>
+        public void StopDancing() => Dance.SendRpc(x => x.IsDancing = false);
+
+        /// <summary>
+        /// Starts dancing.
+        /// </summary>
+        public void StartDanging() => Dance.SendRpc(x => x.IsDancing = true);
     }
 }
\ No newline at end of file

From 4e69cb2b76e967b4647a23382ee7a37f59e3a68b Mon Sep 17 00:00:00 2001
From: Yamato <66829532+louis1706@users.noreply.github.com>
Date: Sat, 10 Feb 2024 01:08:41 +0100
Subject: [PATCH 10/11] Local / world position (#2442)

* Move API from Room to GameEntity

* fix
---
 Exiled.API/Features/Core/GameEntity.cs | 14 ++++++++++++++
 Exiled.API/Features/Room.cs            | 14 --------------
 2 files changed, 14 insertions(+), 14 deletions(-)

diff --git a/Exiled.API/Features/Core/GameEntity.cs b/Exiled.API/Features/Core/GameEntity.cs
index 4085c423ff..32bb44c698 100644
--- a/Exiled.API/Features/Core/GameEntity.cs
+++ b/Exiled.API/Features/Core/GameEntity.cs
@@ -117,6 +117,20 @@ public virtual Quaternion Rotation
         /// <returns>The filtered collection of <see cref="GameEntity" /> objects.</returns>
         public static IEnumerable<GameEntity> GetFarthestEntities(Vector3 vector, float distance) => List.Where(p => p.GameObject.transform && (vector - p.GameObject.transform.position).sqrMagnitude >= distance * distance);
 
+        /// <summary>
+        /// Returns the local space position, based on a world space position.
+        /// </summary>
+        /// <param name="position">World position.</param>
+        /// <returns>Local position, based on the GameEntity.</returns>
+        public Vector3 LocalPosition(Vector3 position) => Transform.InverseTransformPoint(position);
+
+        /// <summary>
+        /// Returns the World position, based on a local space position.
+        /// </summary>
+        /// <param name="offset">Local position.</param>
+        /// <returns>World position, based on the GameEntity.</returns>
+        public Vector3 WorldPosition(Vector3 offset) => Transform.TransformPoint(offset);
+
         /// <inheritdoc/>
         public T AddComponent<T>(string name = "")
             where T : EActor
diff --git a/Exiled.API/Features/Room.cs b/Exiled.API/Features/Room.cs
index da1885ad8c..cb2daf3e7e 100644
--- a/Exiled.API/Features/Room.cs
+++ b/Exiled.API/Features/Room.cs
@@ -332,20 +332,6 @@ public static Room FindParentRoom(GameObject objectInRoom)
         /// <returns><see cref="Room"/> object.</returns>
         public static Room Random(ZoneType zoneType = ZoneType.Unspecified) => (zoneType is not ZoneType.Unspecified ? Get(r => r.Zone.HasFlag(zoneType)) : List).Random();
 
-        /// <summary>
-        /// Returns the local space position, based on a world space position.
-        /// </summary>
-        /// <param name="position">World position.</param>
-        /// <returns>Local position, based on the room.</returns>
-        public Vector3 LocalPosition(Vector3 position) => Transform.InverseTransformPoint(position);
-
-        /// <summary>
-        /// Returns the World position, based on a local space position.
-        /// </summary>
-        /// <param name="offset">Local position.</param>
-        /// <returns>World position, based on the room.</returns>
-        public Vector3 WorldPosition(Vector3 offset) => Transform.TransformPoint(offset);
-
         /// <summary>
         /// Flickers the room's lights off for a duration.
         /// </summary>

From 4a0ccb81bbc512509b983151a1fe6713db87e9c9 Mon Sep 17 00:00:00 2001
From: Yamato <66829532+louis1706@users.noreply.github.com>
Date: Sat, 10 Feb 2024 01:10:12 +0100
Subject: [PATCH 11/11] bool DamageWindow (#2444)

* bool DamageWindow

* .
---
 Exiled.API/Features/Recontainer.cs |  2 +-
 Exiled.API/Features/Window.cs      | 10 ++++------
 2 files changed, 5 insertions(+), 7 deletions(-)

diff --git a/Exiled.API/Features/Recontainer.cs b/Exiled.API/Features/Recontainer.cs
index bdbbfcdf79..4f73ce1096 100644
--- a/Exiled.API/Features/Recontainer.cs
+++ b/Exiled.API/Features/Recontainer.cs
@@ -224,6 +224,6 @@ public static bool IsContainmentSequenceSuccessful
         /// <summary>
         /// Breaks the glass protecting the activator button.
         /// </summary>
-        public static void BreakGlass() => ActivatorWindow.BreakWindow();
+        public static void Break() => ActivatorWindow.Break();
     }
 }
\ No newline at end of file
diff --git a/Exiled.API/Features/Window.cs b/Exiled.API/Features/Window.cs
index a1819c9f57..8a62e79b9b 100644
--- a/Exiled.API/Features/Window.cs
+++ b/Exiled.API/Features/Window.cs
@@ -181,23 +181,21 @@ public static bool TryGet(Func<Window, bool> predicate, out IEnumerable<Window>
         /// <summary>
         /// Break the window.
         /// </summary>
-        public void BreakWindow() => Base.BreakWindow();
+        public void Break() => Base.BreakWindow();
 
         /// <summary>
         /// Damages the window.
         /// </summary>
         /// <param name="amount">The amount of damage to deal.</param>
-        public void DamageWindow(float amount) => Base.ServerDamageWindow(amount);
+        public void Damage(float amount) => Base.ServerDamageWindow(amount);
 
         /// <summary>
         /// Damages the window.
         /// </summary>
         /// <param name="amount">The amount of damage to deal.</param>
         /// <param name="handler">The handler of damage.</param>
-        public void DamageWindow(float amount, DamageHandlerBase handler)
-        {
-            Base.Damage(amount, handler, Vector3.zero);
-        }
+        /// <returns>Whether or not the Window get Damage.</returns>
+        public bool Damage(float amount, DamageHandlerBase handler) => Base.Damage(amount, handler, Vector3.zero);
 
         /// <summary>
         /// Returns the Window in a human-readable format.