Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make all fails when no apps configured and no serve config block #309

Closed
jjgriff93 opened this issue Jul 3, 2023 · 1 comment
Closed
Assignees
Labels
bug Something isn't working
Milestone

Comments

@jjgriff93
Copy link
Member

jjgriff93 commented Jul 3, 2023

Describe the bug
It should be possible to deploy FlowEHR without any serve configuration as it is optional and only required when deploying apps. Currently, if no serve config is provided you get the following error:

  │ Error: "app_auth.0.id": required field is not set
  │ 
  │   with provider["registry.terraform.io/integrations/github"],
  │   on provider.tf line 23, in provider "github":
  │   23: provider "github" {
  │ 
  ╵
  ╷
  │ Error: "app_auth.0.installation_id": required field is not set
  │ 
  │   with provider["registry.terraform.io/integrations/github"],
  │   on provider.tf line 23, in provider "github":
  │   23: provider "github" {
  │ 
  ╵

Expected behavior
make all runs without error when no apps are configured and no serve block provided in config.

The fix
In apps/variables.tf, changing the default values from null to strings will fix this:

default = {
    github_owner               = ""
    github_app_id              = ""
    github_app_installation_id = ""
  }
@jjgriff93 jjgriff93 added the bug Something isn't working label Jul 3, 2023
@jjgriff93 jjgriff93 modified the milestones: 0.2, 0.1 Jul 25, 2023
@jjgriff93
Copy link
Member Author

Fixed in #317

@jjgriff93 jjgriff93 self-assigned this Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

1 participant