Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IdpMetadata#idp_cert_multi should always be assigned #604

Closed
johnnyshields opened this issue Aug 8, 2021 · 2 comments · Fixed by #611
Closed

IdpMetadata#idp_cert_multi should always be assigned #604

johnnyshields opened this issue Aug 8, 2021 · 2 comments · Fixed by #611

Comments

@johnnyshields
Copy link
Collaborator

Currently IdpMetadata#idp_cert_multi is only assigned to a value when the IdP Metadata XML contains multiple unique certs. It would be useful for me if this variable were always assigned, so that I won't get different behavior for the 1 vs. N certificate cases.
@pitbulk
Copy link
Collaborator

pitbulk commented Aug 12, 2021

I'm ok with such behavior change

@johnnyshields johnnyshields mentioned this issue Aug 15, 2021
Merged
@johnnyshields
Copy link
Collaborator Author

PR raised

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@johnnyshields @pitbulk