-
Notifications
You must be signed in to change notification settings - Fork 26
Pull Request Checklist
-
Check the PR.
a. Expect: No Conflicts, no exceptions -
Checkout the branch to your local dev environment
-
Clean all local modified files and build folders – TO DO gulp taks
-
Build the whole project, docs and website: ‘gulp build’
a. Expect: No errors -
Serve and watch the local branch: ‘gulp’
-
Check the local website against the production website
a. Expect: Navigation to be in place
b. Expect: Main layout is the same
c. Expect: No dead links
d. Expect: New guides, components, patterns, starter pages, etc. To be present in the corresponding place -
Check Integrity
a. Expect: No change on current components and patterns or starter pages
b. Expect: New components, patters or starter pages to display and work as intended -
Check Mobile a. Open the local website on a mobile phone or simulator i. Expect: Same functionality on Android and iOS ii. Expect: New functionality to work as intended on Android and iOS
-
Check Other Browsers a. Open the local website on Chrome, Firefox, Safari and IE/Edge – free to download VMs from Microsoft are available i. Expect: Style and Functionality to be the ‘same’ across platforms
-
Check for the Copy Text a. Read the new copy text and try to spot typos and inconsistencies b. Look at the formatting and layout i. Expect: To be the same as similar text elements on the page or siblings pages
-
Check the Code a. Check relevant points on the Code Style guide – TO DO