Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Accessibility] Shellbar action button is missing Alt Text, also missing Aria-label when notificationCount is zero #10956

Closed
itsnode opened this issue Nov 15, 2023 · 0 comments
Assignees
Labels
accessibility use this label for any issue or enhancement related to screenreader/keyboard/etc support
Milestone

Comments

@itsnode
Copy link
Contributor

itsnode commented Nov 15, 2023

Is this a bug, enhancement, or feature request?

Bug

Describe your proposal.

Can you handle that on the application side

no

Which versions of Angular and Fundamental Library for Angular are affected? Please, specify the exact version. (If this is a feature request, use current version.)

latest

If this is a bug, please provide steps for reproducing it; the exact components you are using;

Please provide relevant source code (if applicable).

See pool action button html code, there is no title(for Alt text) and no aria-label for Screen reader(JAWS) when count = 0.

<button fd-button="" fdtype="transparent" fdcozy="" class="fd-button fd-button--transparent fd-shellbar__button" ng-reflect-fd-type="transparent" ng-reflect-fd-cozy="" ng-reflect-glyph="pool" type="button"><fd-icon ng-reflect-glyph="pool" class="sap-icon--pool"></fd-icon><!--ng-container--><!--bindings={
  "ng-reflect-ng-if": "true"
}--><!--bindings={}--><!--bindings={
  "ng-reflect-ng-if": "0"
}--><!--bindings={
  "ng-reflect-ng-if": "false"
}--><!--bindings={
  "ng-reflect-ng-if": "false"
}--></button>
Screenshot 2023-11-14 at 4 18 54 PM

Please provide stackblitz example(s).

https://stackblitz.com/edit/tw3jcd-bgufky?file=src%2Fapp%2Fshellbar-collapsible-example.component.html

In case this is Accessibility related topic, did you consult with an accessibility expert? If not, please do so and share their recommendations.

Did you check the documentation and the API?

Did you search for similar issues?

Is there anything else we should know?

@droshev droshev added the accessibility use this label for any issue or enhancement related to screenreader/keyboard/etc support label Nov 15, 2023
@itsnode itsnode changed the title Shellbar action button is missing Alt Text, also missing Aria-label when notificationCount is zero [Accessibility] Shellbar action button is missing Alt Text, also missing Aria-label when notificationCount is zero Nov 15, 2023
@droshev droshev closed this as completed Dec 1, 2023
@droshev droshev added this to the Sprint 127 milestone Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility use this label for any issue or enhancement related to screenreader/keyboard/etc support
Projects
None yet
2 participants