Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Going to “absolutely” wrong path in path routing doesn’t redirect to the root #281

Closed
dariadomagala-sap opened this issue Dec 7, 2018 · 1 comment
Labels
bug Something isn't working

Comments

@dariadomagala-sap
Copy link
Contributor

Expected result

After going to an "absolutely" wrong path when using path routing (e.g. myapp.com/non-existing-path), Luigi should show an error message, and redirect user to the root.

Actual result

Going to a wrong path shows an error message, but doesn't redirect to the root.

Steps to reproduce

  • open a Luigi app with a path routing
  • go to a non-existing path
  • error is shown but no redirection
@dariadomagala-sap dariadomagala-sap added bug Something isn't working area/luigi labels Dec 7, 2018
@dariadomagala-sap dariadomagala-sap added this to the Backlog_Swinka milestone Dec 7, 2018
@kwiatekus kwiatekus modified the milestones: Backlog_Swinka, Sprint_Swinka_6 Jan 4, 2019
@parostatkiem-zz
Copy link
Contributor

parostatkiem-zz commented Jan 4, 2019

Works on both types of routing now.
PR: #310

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants