Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Console error on clicking on "No" in the confirmation dialog #3229

Closed
aaasarthak opened this issue Mar 17, 2023 · 1 comment · Fixed by #3241
Closed

Console error on clicking on "No" in the confirmation dialog #3229

aaasarthak opened this issue Mar 17, 2023 · 1 comment · Fixed by #3241
Assignees

Comments

@aaasarthak
Copy link

Description

  • I have a form in my client(microfrontend application), where if the user doesn't save before navigating I want to give a confirmation dialog for the unsaved changes.
  • For which I am using setDirtyStatus() in the client application which gives the confirmation dialog if the user tries to navigate from the shellbar navigation options.
  • But if we click on "No" in the confirmation dialog, it closes the dialog with a console error.

Expected result

It should not throw the console error on selecting "No" in the confirmation dialog

Actual result

It throws the console error

Steps to reproduce

  • setDirtyStatus as true from your microfrontend
  • Try navigating outside the application
  • There will be a confirmation modal to tell that unsaved changes will be lost
  • Select "No" on that model
  • Observe that the dialog closes and application behavior is as expected, but there is an error in the console.

Screenshots

image
image

@ndricimrr
Copy link
Contributor

Hi @aaasarthak . This issue should be resolved on the next release. Alternatively, you can use the next nightly release for luigi-project/core as of tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants