From 2e8e723b5679cca07965c63d2c271b69dba21350 Mon Sep 17 00:00:00 2001 From: UlianaMunich Date: Thu, 8 Jul 2021 12:22:56 +0200 Subject: [PATCH 1/5] Fix issue with hidden text in new user menu --- core/src/Authorization.html | 4 ++++ .../src/luigi-config/extended/settings.js | 12 ++++++------ 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/core/src/Authorization.html b/core/src/Authorization.html index cf55ac0f5c..b3ecc40cf4 100644 --- a/core/src/Authorization.html +++ b/core/src/Authorization.html @@ -329,5 +329,9 @@ overflow-y: auto; padding-left: 0.5rem; padding-right: 0.5rem; + /*TODO: check if FD Styles > 0.18.0 has fixed it*/ + .fd-list__title { + line-height: var(--sapContent_LineHeight, 1.4); + } } diff --git a/test/e2e-test-application/src/luigi-config/extended/settings.js b/test/e2e-test-application/src/luigi-config/extended/settings.js index 13c12cff6c..2f738cb18f 100644 --- a/test/e2e-test-application/src/luigi-config/extended/settings.js +++ b/test/e2e-test-application/src/luigi-config/extended/settings.js @@ -11,7 +11,7 @@ class Settings { appLoadingIndicator = { hideAutomatically: false }; - profileType = ''; // Options: simple | Fiori3 + profileType = 'Fiori3'; // Options: simple | Fiori3 responsiveNavigation = 'Fiori3'; // Options: simple | simpleMobileOnly | semiCollapsible | Fiori3 sideNavFooterText = `Luigi Client: ${version || 'unknown'}`; thirdPartyCookieCheck = { @@ -57,11 +57,11 @@ class Settings { // }; // }; // globalSideNavigation = true; - // experimental = { - // profileMenuFiori3: true, - // globalNav: true, - // webcomponents:true - // }; + experimental = { + profileMenuFiori3: true + // globalNav: true, + // webcomponents:true + }; } export const settings = new Settings(); From 7cd5c51be3cff907c6e29f759aa4e9ed3dbcb905 Mon Sep 17 00:00:00 2001 From: UlianaMunich Date: Thu, 8 Jul 2021 12:27:30 +0200 Subject: [PATCH 2/5] revert setting.js to default one --- .../src/luigi-config/extended/settings.js | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/test/e2e-test-application/src/luigi-config/extended/settings.js b/test/e2e-test-application/src/luigi-config/extended/settings.js index 2f738cb18f..33087bbcc4 100644 --- a/test/e2e-test-application/src/luigi-config/extended/settings.js +++ b/test/e2e-test-application/src/luigi-config/extended/settings.js @@ -11,7 +11,7 @@ class Settings { appLoadingIndicator = { hideAutomatically: false }; - profileType = 'Fiori3'; // Options: simple | Fiori3 + profileType = ''; // Options: simple | Fiori3 responsiveNavigation = 'Fiori3'; // Options: simple | simpleMobileOnly | semiCollapsible | Fiori3 sideNavFooterText = `Luigi Client: ${version || 'unknown'}`; thirdPartyCookieCheck = { @@ -56,12 +56,9 @@ class Settings { // } // }; // }; - // globalSideNavigation = true; - experimental = { - profileMenuFiori3: true - // globalNav: true, - // webcomponents:true - }; + // experimental = { + // profileMenuFiori3: true + // }; } export const settings = new Settings(); From 961670a20a3fea8bcec51fb95846463ca18da121 Mon Sep 17 00:00:00 2001 From: UlianaMunich Date: Thu, 8 Jul 2021 12:28:43 +0200 Subject: [PATCH 3/5] a tiny fix for user settings --- .../src/luigi-config/extended/settings.js | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/test/e2e-test-application/src/luigi-config/extended/settings.js b/test/e2e-test-application/src/luigi-config/extended/settings.js index 33087bbcc4..13c12cff6c 100644 --- a/test/e2e-test-application/src/luigi-config/extended/settings.js +++ b/test/e2e-test-application/src/luigi-config/extended/settings.js @@ -56,8 +56,11 @@ class Settings { // } // }; // }; + // globalSideNavigation = true; // experimental = { - // profileMenuFiori3: true + // profileMenuFiori3: true, + // globalNav: true, + // webcomponents:true // }; } From 84acd08a0fba102cc698e051516444b9c2f643a9 Mon Sep 17 00:00:00 2001 From: UlianaMunich Date: Fri, 9 Jul 2021 09:13:21 +0200 Subject: [PATCH 4/5] enable an attribute in config to check if Travis pass failing tests --- test/e2e-test-application/src/luigi-config/extended/settings.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/e2e-test-application/src/luigi-config/extended/settings.js b/test/e2e-test-application/src/luigi-config/extended/settings.js index 13c12cff6c..d3d6f9df1e 100644 --- a/test/e2e-test-application/src/luigi-config/extended/settings.js +++ b/test/e2e-test-application/src/luigi-config/extended/settings.js @@ -11,7 +11,7 @@ class Settings { appLoadingIndicator = { hideAutomatically: false }; - profileType = ''; // Options: simple | Fiori3 + profileType = 'simple'; // Options: simple | Fiori3 responsiveNavigation = 'Fiori3'; // Options: simple | simpleMobileOnly | semiCollapsible | Fiori3 sideNavFooterText = `Luigi Client: ${version || 'unknown'}`; thirdPartyCookieCheck = { From 82fa77b501dec167c919807ac374a480500d12cf Mon Sep 17 00:00:00 2001 From: UlianaMunich Date: Fri, 9 Jul 2021 10:14:26 +0200 Subject: [PATCH 5/5] another try to pass travis issues --- test/e2e-test-application/src/luigi-config/extended/settings.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/e2e-test-application/src/luigi-config/extended/settings.js b/test/e2e-test-application/src/luigi-config/extended/settings.js index d3d6f9df1e..13c12cff6c 100644 --- a/test/e2e-test-application/src/luigi-config/extended/settings.js +++ b/test/e2e-test-application/src/luigi-config/extended/settings.js @@ -11,7 +11,7 @@ class Settings { appLoadingIndicator = { hideAutomatically: false }; - profileType = 'simple'; // Options: simple | Fiori3 + profileType = ''; // Options: simple | Fiori3 responsiveNavigation = 'Fiori3'; // Options: simple | simpleMobileOnly | semiCollapsible | Fiori3 sideNavFooterText = `Luigi Client: ${version || 'unknown'}`; thirdPartyCookieCheck = {