From 877ce7656a18d0686ee6abb525ef7a4ff3734216 Mon Sep 17 00:00:00 2001 From: Jesus Real <8238188+jesusreal@users.noreply.github.com> Date: Fri, 2 Aug 2019 15:48:25 +0200 Subject: [PATCH 01/16] Add docu for responsive app setup --- docs/luigi-ux-features.md | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/docs/luigi-ux-features.md b/docs/luigi-ux-features.md index 53b823f01f..347dba6bf4 100644 --- a/docs/luigi-ux-features.md +++ b/docs/luigi-ux-features.md @@ -8,3 +8,16 @@ By default, the Luigi content, including the top navigation, the left navigation However, you can render the Luigi content in any other HTML container. It can be useful if you want to add a header or a footer on top of the Luigi content. To use this feature, add the `luigi-app-root` custom HTML attribute to the HTML tag in which you want to render the Luigi content. >**NOTE:** If you render the Luigi content in a custom container, the container is positioned relatively when you apply your own CSS. Also, set the height of the Luigi custom container either in **px** or **vh**. + + +### Responsive app setup + +There are a couple quick adjustments that can be applied to the Luigi application, that will improve the user experience on mobile devices like smartphones or tables. + +In first place, it is recommended to add following to your _index.html_, for the Luigi app to be best rendered on a mobile device. + +```html + +``` + +Apart from that, it is also possible to make the left navigation responsive. To do so, some additional settings need to be applied as specified [here](./general-settings.md) From 68dea319cdda3b9aadc19a34637adcc8b4060caa Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jes=C3=BAs=20Real=20Serrano?= <8238188+jesusreal@users.noreply.github.com> Date: Wed, 7 Aug 2019 10:44:31 +0200 Subject: [PATCH 02/16] Apply suggestions from code review Co-Authored-By: Barbara Szwarc --- docs/luigi-ux-features.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/luigi-ux-features.md b/docs/luigi-ux-features.md index 347dba6bf4..af9b8d6f08 100644 --- a/docs/luigi-ux-features.md +++ b/docs/luigi-ux-features.md @@ -10,14 +10,14 @@ However, you can render the Luigi content in any other HTML container. It can be >**NOTE:** If you render the Luigi content in a custom container, the container is positioned relatively when you apply your own CSS. Also, set the height of the Luigi custom container either in **px** or **vh**. -### Responsive app setup +### Responsive application setup -There are a couple quick adjustments that can be applied to the Luigi application, that will improve the user experience on mobile devices like smartphones or tables. +You can quickly adjust the Luigi application to improve user experience on mobile devices like smartphones or tablets. -In first place, it is recommended to add following to your _index.html_, for the Luigi app to be best rendered on a mobile device. +* Add the following line to your `index.html` file for the Luigi application to render well on a mobile device: ```html ``` -Apart from that, it is also possible to make the left navigation responsive. To do so, some additional settings need to be applied as specified [here](./general-settings.md) +* Make the left navigation responsive by applying [additional settings](./general-settings.md) From e0690a2b25d276a34c51be277bc4397678dce570 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jes=C3=BAs=20Real=20Serrano?= <8238188+jesusreal@users.noreply.github.com> Date: Wed, 7 Aug 2019 11:24:09 +0200 Subject: [PATCH 03/16] Apply suggestions from code review Co-Authored-By: Barbara Szwarc --- docs/luigi-ux-features.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/luigi-ux-features.md b/docs/luigi-ux-features.md index af9b8d6f08..1533c07a43 100644 --- a/docs/luigi-ux-features.md +++ b/docs/luigi-ux-features.md @@ -12,7 +12,7 @@ However, you can render the Luigi content in any other HTML container. It can be ### Responsive application setup -You can quickly adjust the Luigi application to improve user experience on mobile devices like smartphones or tablets. +You can quickly adjust the Luigi application to improve user experience on mobile devices, such as smartphones or tablets. Here are some examples: * Add the following line to your `index.html` file for the Luigi application to render well on a mobile device: @@ -20,4 +20,4 @@ You can quickly adjust the Luigi application to improve user experience on mobil ``` -* Make the left navigation responsive by applying [additional settings](./general-settings.md) +* Define and apply [additional settings](./general-settings.md) to make the left navigation responsive. From 4a567bc82aee4cf10bb207be2bcf42b30f3f0ac3 Mon Sep 17 00:00:00 2001 From: JohannesDoberer Date: Thu, 8 Aug 2019 11:13:26 +0200 Subject: [PATCH 04/16] Update luigi-ux-features.md --- docs/luigi-ux-features.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/luigi-ux-features.md b/docs/luigi-ux-features.md index 1533c07a43..25b0ba5b29 100644 --- a/docs/luigi-ux-features.md +++ b/docs/luigi-ux-features.md @@ -20,4 +20,4 @@ You can quickly adjust the Luigi application to improve user experience on mobil ``` -* Define and apply [additional settings](./general-settings.md) to make the left navigation responsive. +* Define and apply [responsiveNavigation](./general-settings.md) settings to make the left navigation responsive. From 7ef9b82f0dba8230a61a35dfc4ded6d3a1bdab2b Mon Sep 17 00:00:00 2001 From: Jesus Real <8238188+jesusreal@users.noreply.github.com> Date: Thu, 22 Aug 2019 14:10:44 +0200 Subject: [PATCH 05/16] Add debugging lines for travis issues --- .travis.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.travis.yml b/.travis.yml index 3ae81597a2..841af46b50 100644 --- a/.travis.yml +++ b/.travis.yml @@ -38,6 +38,8 @@ jobs: - name: 'Unit Tests' script: - echo 'core' && ls core/node_modules | wc -l && echo 'client' && ls client/node_modules | wc -l + - cat /home/travis/build/SAP/luigi/core/test/utilities/helpers/state-helpers.spec.js + - cat /home/travis/build/SAP/luigi/core/src/utilities/helpers/state-helpers.js - npm test --prefix core before_cache: - rm -rf ~/.npm/_logs From bc27dfb4747cc6651195f014af45320343018f3c Mon Sep 17 00:00:00 2001 From: Markus Edenhauser <1720843+maxmarkus@users.noreply.github.com> Date: Thu, 22 Aug 2019 19:04:15 +0200 Subject: [PATCH 06/16] state-helpers debug --- .travis.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.travis.yml b/.travis.yml index 841af46b50..2bf34d1dae 100644 --- a/.travis.yml +++ b/.travis.yml @@ -21,6 +21,8 @@ jobs: - lerna bootstrap --ci --ignore "*luigi-sample-vue" - echo 'core' && ls core/node_modules | wc -l && echo 'client' && ls client/node_modules | wc -l - lerna run bundle --ignore "*luigi-sample-vue" + - cat /home/travis/build/SAP/luigi/core/test/utilities/helpers/state-helpers.spec.js + - cat /home/travis/build/SAP/luigi/core/src/utilities/helpers/state-helpers.js - du -sh before_cache: - rm -rf ~/.npm/_logs From 25cf8fa98e8c82a1fccf5194f301e1372f435706 Mon Sep 17 00:00:00 2001 From: Markus Edenhauser <1720843+maxmarkus@users.noreply.github.com> Date: Thu, 22 Aug 2019 19:20:41 +0200 Subject: [PATCH 07/16] state helper test --- .travis.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.travis.yml b/.travis.yml index 2bf34d1dae..67ec3502d7 100644 --- a/.travis.yml +++ b/.travis.yml @@ -15,14 +15,13 @@ jobs: - stage: 'Precache' name: 'Install and build' script: + - cat /home/travis/build/SAP/luigi/core/src/utilities/helpers/state-helpers.js - pwd && ls $TRAVIS_BUILD_DIR - export CYPRESS_CACHE_FOLDER=$TRAVIS_BUILD_DIR/cypress-binary-cache - npm i -g lerna - lerna bootstrap --ci --ignore "*luigi-sample-vue" - echo 'core' && ls core/node_modules | wc -l && echo 'client' && ls client/node_modules | wc -l - lerna run bundle --ignore "*luigi-sample-vue" - - cat /home/travis/build/SAP/luigi/core/test/utilities/helpers/state-helpers.spec.js - - cat /home/travis/build/SAP/luigi/core/src/utilities/helpers/state-helpers.js - du -sh before_cache: - rm -rf ~/.npm/_logs From e64e6843ab23bfcad2312610e2a77363e59ad0ac Mon Sep 17 00:00:00 2001 From: Markus Edenhauser <1720843+maxmarkus@users.noreply.github.com> Date: Thu, 22 Aug 2019 19:26:27 +0200 Subject: [PATCH 08/16] debugging, disable cache --- .travis.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.travis.yml b/.travis.yml index 67ec3502d7..91b4a56a19 100644 --- a/.travis.yml +++ b/.travis.yml @@ -3,10 +3,10 @@ node_js: - '11.14' #TODO: change it to 'node' once Travis supports the newest version dist: trusty install: skip -cache: - directories: - - $TRAVIS_BUILD_DIR - - $HOME/.cache/Cypress +# cache: +# directories: +# - $TRAVIS_BUILD_DIR +# - $HOME/.cache/Cypress notifications: slack: secure: wiOchVgoiKNUikjCeIhsuv3Y5jolFud6ercdZdO3+JigQqkmoAC95f2jKTYEdplJWyJr8JY6z0+UJNceHyr5YJx/l1wpm6Zq+3H4dq/V0yUXH1uhw2eaTzweX2vjfw0bzewEdc1CGl4kSfdyTajnbKgt+mtnrAV9lPqiXYSOOJTu5BCFomi7u2GhAz1JjBK6P4Ar2jXm+oc81nYjj40P8bZFlA7Rjm0hNN42MMkKvnD8OHztL3EwezKHXlQW7fN4eOrhPOMbT3NRU72g9Nir+lfoKJlch1zPoHXQ7DRp41uGyHV/qfvfRLzXwxftZK6kdvzMe0eI0i1aIm0R6AE0bLphB2o/klJzyQpqSiQgETTH0qJN+3px2kddGrw7Me+UNC/1zZrt1MJfWf0h6WjXTsPDJf3ajLsn8OoIeBTRZbAb9as3UWQZcknuuMf8oGUzZkrZNMWYqo3py0+qWm4wSbWXWVUCgVAIYA6oEADwq37z59HySGkyHI4gEPzxsYODfCuvO4pJX1h4vEyH7w2IigwhDAPq5G4Vdez9ZFS96p/LSCF+iH8yWMy294u8wk5ofWUutFFv0JC45LQBXu51a2TeQkalwVn4DiuxxHE6jZieREw75YFjra4jpWsyziWkzshGT75NCra6cKAbNa4T8n6Pm3ogjEPeeWAO3psgSdo= From cab93f01475d0c9a512cd03c46b3ed2b9ccdad3e Mon Sep 17 00:00:00 2001 From: Markus Edenhauser <1720843+maxmarkus@users.noreply.github.com> Date: Thu, 22 Aug 2019 20:15:59 +0200 Subject: [PATCH 09/16] find build-dir --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 91b4a56a19..4042ed0649 100644 --- a/.travis.yml +++ b/.travis.yml @@ -15,7 +15,7 @@ jobs: - stage: 'Precache' name: 'Install and build' script: - - cat /home/travis/build/SAP/luigi/core/src/utilities/helpers/state-helpers.js + - find $TRAVIS_BUILD_DIR - pwd && ls $TRAVIS_BUILD_DIR - export CYPRESS_CACHE_FOLDER=$TRAVIS_BUILD_DIR/cypress-binary-cache - npm i -g lerna From cf7778fb3bf495a00a97b5fb5c913f182752b25f Mon Sep 17 00:00:00 2001 From: Markus Edenhauser <1720843+maxmarkus@users.noreply.github.com> Date: Thu, 22 Aug 2019 20:19:34 +0200 Subject: [PATCH 10/16] debug cat --- .travis.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.travis.yml b/.travis.yml index 4042ed0649..1bd2508c31 100644 --- a/.travis.yml +++ b/.travis.yml @@ -16,6 +16,7 @@ jobs: name: 'Install and build' script: - find $TRAVIS_BUILD_DIR + - cat $TRAVIS_BUILD_DIR/SAP/luigi/core/src/utilities/helpers/state-helpers.js - pwd && ls $TRAVIS_BUILD_DIR - export CYPRESS_CACHE_FOLDER=$TRAVIS_BUILD_DIR/cypress-binary-cache - npm i -g lerna From 60ded7c9445424bb1f67d86923a4fe0cbe4486af Mon Sep 17 00:00:00 2001 From: Markus Edenhauser <1720843+maxmarkus@users.noreply.github.com> Date: Thu, 22 Aug 2019 20:23:11 +0200 Subject: [PATCH 11/16] debug state path --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 1bd2508c31..3963411978 100644 --- a/.travis.yml +++ b/.travis.yml @@ -16,7 +16,7 @@ jobs: name: 'Install and build' script: - find $TRAVIS_BUILD_DIR - - cat $TRAVIS_BUILD_DIR/SAP/luigi/core/src/utilities/helpers/state-helpers.js + - cat $TRAVIS_BUILD_DIR/core/src/utilities/helpers/state-helpers.js - pwd && ls $TRAVIS_BUILD_DIR - export CYPRESS_CACHE_FOLDER=$TRAVIS_BUILD_DIR/cypress-binary-cache - npm i -g lerna From e9182915e2d0920255176651e5ad9a4431f53f43 Mon Sep 17 00:00:00 2001 From: Markus Edenhauser <1720843+maxmarkus@users.noreply.github.com> Date: Thu, 22 Aug 2019 20:27:04 +0200 Subject: [PATCH 12/16] debug with cache --- .travis.yml | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/.travis.yml b/.travis.yml index 3963411978..cc9e744fa4 100644 --- a/.travis.yml +++ b/.travis.yml @@ -3,10 +3,10 @@ node_js: - '11.14' #TODO: change it to 'node' once Travis supports the newest version dist: trusty install: skip -# cache: -# directories: -# - $TRAVIS_BUILD_DIR -# - $HOME/.cache/Cypress +cache: + directories: + - $TRAVIS_BUILD_DIR + - $HOME/.cache/Cypress notifications: slack: secure: wiOchVgoiKNUikjCeIhsuv3Y5jolFud6ercdZdO3+JigQqkmoAC95f2jKTYEdplJWyJr8JY6z0+UJNceHyr5YJx/l1wpm6Zq+3H4dq/V0yUXH1uhw2eaTzweX2vjfw0bzewEdc1CGl4kSfdyTajnbKgt+mtnrAV9lPqiXYSOOJTu5BCFomi7u2GhAz1JjBK6P4Ar2jXm+oc81nYjj40P8bZFlA7Rjm0hNN42MMkKvnD8OHztL3EwezKHXlQW7fN4eOrhPOMbT3NRU72g9Nir+lfoKJlch1zPoHXQ7DRp41uGyHV/qfvfRLzXwxftZK6kdvzMe0eI0i1aIm0R6AE0bLphB2o/klJzyQpqSiQgETTH0qJN+3px2kddGrw7Me+UNC/1zZrt1MJfWf0h6WjXTsPDJf3ajLsn8OoIeBTRZbAb9as3UWQZcknuuMf8oGUzZkrZNMWYqo3py0+qWm4wSbWXWVUCgVAIYA6oEADwq37z59HySGkyHI4gEPzxsYODfCuvO4pJX1h4vEyH7w2IigwhDAPq5G4Vdez9ZFS96p/LSCF+iH8yWMy294u8wk5ofWUutFFv0JC45LQBXu51a2TeQkalwVn4DiuxxHE6jZieREw75YFjra4jpWsyziWkzshGT75NCra6cKAbNa4T8n6Pm3ogjEPeeWAO3psgSdo= @@ -15,7 +15,7 @@ jobs: - stage: 'Precache' name: 'Install and build' script: - - find $TRAVIS_BUILD_DIR + # - find $TRAVIS_BUILD_DIR - cat $TRAVIS_BUILD_DIR/core/src/utilities/helpers/state-helpers.js - pwd && ls $TRAVIS_BUILD_DIR - export CYPRESS_CACHE_FOLDER=$TRAVIS_BUILD_DIR/cypress-binary-cache @@ -23,6 +23,7 @@ jobs: - lerna bootstrap --ci --ignore "*luigi-sample-vue" - echo 'core' && ls core/node_modules | wc -l && echo 'client' && ls client/node_modules | wc -l - lerna run bundle --ignore "*luigi-sample-vue" + - cat $TRAVIS_BUILD_DIR/core/src/utilities/helpers/state-helpers.js - du -sh before_cache: - rm -rf ~/.npm/_logs @@ -40,8 +41,7 @@ jobs: - name: 'Unit Tests' script: - echo 'core' && ls core/node_modules | wc -l && echo 'client' && ls client/node_modules | wc -l - - cat /home/travis/build/SAP/luigi/core/test/utilities/helpers/state-helpers.spec.js - - cat /home/travis/build/SAP/luigi/core/src/utilities/helpers/state-helpers.js + - cat $TRAVIS_BUILD_DIR/core/src/utilities/helpers/state-helpers.js - npm test --prefix core before_cache: - rm -rf ~/.npm/_logs From 51733721b465fc11ac99090a8d2efae8dacf7e47 Mon Sep 17 00:00:00 2001 From: Markus Edenhauser <1720843+maxmarkus@users.noreply.github.com> Date: Thu, 22 Aug 2019 20:41:39 +0200 Subject: [PATCH 13/16] debug cache node_modules --- .travis.yml | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index cc9e744fa4..ea034ffb0b 100644 --- a/.travis.yml +++ b/.travis.yml @@ -5,7 +5,13 @@ dist: trusty install: skip cache: directories: - - $TRAVIS_BUILD_DIR + - $TRAVIS_BUILD_DIR/node_modules + - $TRAVIS_BUILD_DIR/client + - $TRAVIS_BUILD_DIR/client/node_modules + - $TRAVIS_BUILD_DIR/core/public + - $TRAVIS_BUILD_DIR/core/node_modules + - $TRAVIS_BUILD_DIR/core/examples/luigi-sample-angular/node_modules + - $TRAVIS_BUILD_DIR/cypress-binary-cache - $HOME/.cache/Cypress notifications: slack: From 825a2997d4d64818e54e07844911a2948213281b Mon Sep 17 00:00:00 2001 From: Markus Edenhauser <1720843+maxmarkus@users.noreply.github.com> Date: Thu, 22 Aug 2019 21:09:47 +0200 Subject: [PATCH 14/16] git status --- scripts/docuCheck.sh | 2 ++ 1 file changed, 2 insertions(+) diff --git a/scripts/docuCheck.sh b/scripts/docuCheck.sh index 384f701190..05ee95c08a 100755 --- a/scripts/docuCheck.sh +++ b/scripts/docuCheck.sh @@ -65,6 +65,8 @@ validateMdChanges() { fi } +echoe "git status" +git status # add all folders that are containing documentation steps for FOLDER in "${LUIGI_FOLDERS[@]}" From cec1ec3a487dda126f0acb2643bc45d1cdb8e9e3 Mon Sep 17 00:00:00 2001 From: Markus Edenhauser <1720843+maxmarkus@users.noreply.github.com> Date: Thu, 22 Aug 2019 21:18:40 +0200 Subject: [PATCH 15/16] core api docs --- docs/luigi-core-api.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/luigi-core-api.md b/docs/luigi-core-api.md index 52c54d320d..1cd8509f6f 100644 --- a/docs/luigi-core-api.md +++ b/docs/luigi-core-api.md @@ -57,8 +57,8 @@ Tells Luigi that the configuration has been changed. Luigi will update the appli ##### Parameters -- `scope` **...[string](https://developer.mozilla.org/docs/Web/JavaScript/Reference/Global_Objects/String)** one or more scope selectors specifying what parts of the configuration were changed. If no scope selector is provided the whole configuration is considered changed.

- These scope selectors are supported: +- `scope` **...[string](https://developer.mozilla.org/docs/Web/JavaScript/Reference/Global_Objects/String)** one or more scope selectors specifying what parts of the configuration were changed. If no scope selector is provided, the whole configuration is considered changed.

+ The supported scope selectors are:

  • navigation: the navigation part of the configuration was changed. This includes navigation nodes, the context switcher, the product switcher and the profile menu.
    • From fc2518f99c02f75be0128993fe4f28d3256964a0 Mon Sep 17 00:00:00 2001 From: Markus Edenhauser <1720843+maxmarkus@users.noreply.github.com> Date: Fri, 23 Aug 2019 08:46:07 +0200 Subject: [PATCH 16/16] cleanup --- .travis.yml | 5 ----- 1 file changed, 5 deletions(-) diff --git a/.travis.yml b/.travis.yml index ea034ffb0b..e92f4a6f8d 100644 --- a/.travis.yml +++ b/.travis.yml @@ -21,15 +21,11 @@ jobs: - stage: 'Precache' name: 'Install and build' script: - # - find $TRAVIS_BUILD_DIR - - cat $TRAVIS_BUILD_DIR/core/src/utilities/helpers/state-helpers.js - - pwd && ls $TRAVIS_BUILD_DIR - export CYPRESS_CACHE_FOLDER=$TRAVIS_BUILD_DIR/cypress-binary-cache - npm i -g lerna - lerna bootstrap --ci --ignore "*luigi-sample-vue" - echo 'core' && ls core/node_modules | wc -l && echo 'client' && ls client/node_modules | wc -l - lerna run bundle --ignore "*luigi-sample-vue" - - cat $TRAVIS_BUILD_DIR/core/src/utilities/helpers/state-helpers.js - du -sh before_cache: - rm -rf ~/.npm/_logs @@ -47,7 +43,6 @@ jobs: - name: 'Unit Tests' script: - echo 'core' && ls core/node_modules | wc -l && echo 'client' && ls client/node_modules | wc -l - - cat $TRAVIS_BUILD_DIR/core/src/utilities/helpers/state-helpers.js - npm test --prefix core before_cache: - rm -rf ~/.npm/_logs