Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS test failures #148

Closed
tmbrbr opened this issue Jul 5, 2023 · 4 comments
Closed

JS test failures #148

tmbrbr opened this issue Jul 5, 2023 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@tmbrbr
Copy link
Contributor

tmbrbr commented Jul 5, 2023

There are some JavaScript tests which are currently unsuccessful with Foxhound, but successful with upstream Firefox.

To reproduce:

cp cp taintfox_mozconfig_spidermonkey .mozconfig
./mach build
./mach jstest

Currently gives error:

[44096|   10|    0| 8153] 100% ======================================>| 145.5s
REGRESSIONS
    non262/String/replace-rope-empty.js
    non262/String/thisv-error.js
    test262/built-ins/String/prototype/padStart/observable-operations.js
    test262/built-ins/String/prototype/replace/replaceValue-evaluation-order.js
    test262/built-ins/String/prototype/replace/replaceValue-evaluation-order-regexp-object.js
    test262/built-ins/String/prototype/repeat/return-abrupt-from-this-as-symbol.js
    test262/built-ins/String/prototype/repeat/return-abrupt-from-this.js
    test262/built-ins/String/prototype/padEnd/observable-operations.js
    test262/built-ins/Function/internals/Call/class-ctor-realm.js
    taint/json.js
FAIL

The json.js test is addressed in #145, but the others should be looked at.

@tmbrbr tmbrbr added the bug Something isn't working label Jul 5, 2023
@tmbrbr
Copy link
Contributor Author

tmbrbr commented Aug 8, 2023

Some tests failures addressed in #151, currently down to

[44178|    4|    0| 8138] 100% ======================================>| 118.3s
REGRESSIONS
    non262/String/replace-rope-empty.js
    test262/built-ins/String/prototype/repeat/return-abrupt-from-this.js
    test262/built-ins/String/prototype/repeat/return-abrupt-from-this-as-symbol.js
    test262/built-ins/Function/internals/Call/class-ctor-realm.js
FAIL

@tmbrbr tmbrbr self-assigned this Aug 8, 2023
@tmbrbr
Copy link
Contributor Author

tmbrbr commented Aug 8, 2023

Some updates:

@tmbrbr
Copy link
Contributor Author

tmbrbr commented Aug 9, 2023

More info:

  • Commit 48c020e actually fixes the last test (previously i had marked it as ignored)
  • Commit 57556fc adds skipped tests to the result (previously there were marked as passed)

@tmbrbr
Copy link
Contributor Author

tmbrbr commented Aug 10, 2023

All the JS tests are passing now! Foxhound is (almost) ECMA 262 compliant!

@tmbrbr tmbrbr closed this as completed Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant