[FEATURE] generateFlexChangesBundle: Handle minUI5Version as array #1009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Lonwyr
force-pushed
the
minUI5VersionArrays
branch
from
ea5d00c to
df3c9bb
Compare
|
LGTM. I would prefer to change the base branch of this PR to "v3". So we can release this feature together with a UI5 Tooling v3 minor release. |
|
LGTM
We had a quick discussion today. For v4 ( |
Lonwyr
force-pushed
the
minUI5VersionArrays
branch
from
1be174e to
1004610
Compare
|
The pull request was update to target v3. |
flovogt
previously approved these changes
Apr 18, 2024
Lonwyr
force-pushed
the
minUI5VersionArrays
branch
2 times, most recently
from
b4c1f21 to
f5da889
Compare
…ng and array With the upcoming UI5 2.x the manifest may contain a minUI5Version with multiple entries. This change enables the generateFlexChangesBundle to understand the new syntax. The language check kindly pointed out some words to improve. With this commit the proposals of the check are applied.
Lonwyr
force-pushed
the
minUI5VersionArrays
branch
from
f5da889 to
0c64ca4
Compare
matz3
approved these changes
Apr 24, 2024
RandomByte
changed the title
RandomByte
approved these changes
Apr 24, 2024
RandomByte
pushed a commit
that referenced
this pull request
Apr 24, 2024
…1009) With the upcoming UI5 2.x the manifest may contain a minUI5Version with multiple entries as described in the AppDescriptor schema (internal PR 499). This change enables the generateFlexChangesBundle to understand the new syntax in addition, the tests for the generateFlexChangesBundle were enhanced to check better their complete functionality - boy scouted! JIRA: CLOUDIOI-1170 (cherry picked from commit 45c9b7e)
|
Cherry-pick for main: #1011 |
RandomByte
pushed a commit
that referenced
this pull request
Apr 24, 2024
…1009) With the upcoming UI5 2.x the manifest may contain a minUI5Version with multiple entries as described in the AppDescriptor schema (internal PR 499). This change enables the generateFlexChangesBundle to understand the new syntax in addition, the tests for the generateFlexChangesBundle were enhanced to check better their complete functionality - boy scouted! JIRA: CLOUDIOI-1170 (cherry picked from commit 45c9b7e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
generateFlexChangesBundle understands minUI5Version as string and array
With the upcoming UI5 2.x the manifest may contain a minUI5Version with multiple entries as described in the AppDescriptor schema (internal PR 499). This change enables the generateFlexChangesBundle to understand the new syntax
in addition, the tests for the generateFlexChangesBundle were enhanced to check better their complete functionality - boy scouted!
JIRA: CLOUDIOI-1170
Pull Request Checklist