Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Bundling: merge dependency analysis results with raw module infos #340

Merged
merged 5 commits into from
Oct 11, 2019

Conversation

codeworrior
Copy link
Member

@coveralls
Copy link

coveralls commented Sep 22, 2019

Coverage Status

Coverage increased (+1.04%) to 90.1% when pulling 448022d on packaging-modules-exposing-global-vars into 7a560b4 on master.

@codeworrior
Copy link
Member Author

Note reg. the 2nd commit 265e5b6:
Due to the wrong handling of findResource's result, all bundles have been rated as 'decomposable' and the then needed but missing embedded resources caused 'uncaught promise rejection' errors.

Note to self: According to its name, findResource should not fail with an error but return null. Another getResource method could be introduced with the current behavior of findResource - if needed.

@codeworrior codeworrior requested a review from matz3 September 25, 2019 00:51
lib/lbt/bundle/Resolver.js Outdated Show resolved Hide resolved
@codeworrior codeworrior requested a review from matz3 September 25, 2019 11:47
@codeworrior
Copy link
Member Author

Note: this PR requires a merge of PR #341 to make the unit test for bundles work. Without that PR, the content of bundle modules is not properly recognized.

@codeworrior codeworrior force-pushed the packaging-modules-exposing-global-vars branch from 6b11d65 to 189da90 Compare September 30, 2019 21:08
@codeworrior
Copy link
Member Author

@kristian could you please test this PR again in your context? The new unit and integration tests should cover your scenario, too. But I might have missed something.

@codeworrior codeworrior requested a review from RandomByte October 8, 2019 06:36
@codeworrior codeworrior merged commit af4318a into master Oct 11, 2019
@codeworrior codeworrior deleted the packaging-modules-exposing-global-vars branch October 11, 2019 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preload bundles do not support modules defining global variables
3 participants