Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Support writing 'bundles' config as part of a bundle #396

Merged
merged 8 commits into from
Jun 1, 2021

Conversation

codeworrior
Copy link
Member

When a bundle is created, sections can be added that will be written as
sap.ui.loader.config({bundlesUI5:{...}}) information. Each section of
type 'bundleInfo' represents one single bundle. The section name is the
bundle name, the modules in the section are the modules of the bundle.

It is currently not yet possible to reuse existing bundle definitions to
define the content of such a section.

@coveralls
Copy link

coveralls commented Jan 9, 2020

Coverage Status

Coverage decreased (-0.1%) to 94.72% when pulling c5db925 on support-bundle-info-section-in-bundles into 1a0b4ab on master.

codeworrior and others added 2 commits May 21, 2021 11:02
When a bundle is created, sections can be added that will be written as
sap.ui.loader.config({bundlesUI5:{...}}) information. Each section of
type 'bundleInfo' represents one single bundle. The section name is the
bundle name, the modules in the section are the modules of the bundle.

It is currently not yet possible to reuse existing bundle definitions to
define the content of such a section.
@RandomByte RandomByte force-pushed the support-bundle-info-section-in-bundles branch from 5c6cff8 to 41fd727 Compare May 21, 2021 09:03
@RandomByte RandomByte requested a review from svbender May 21, 2021 09:22
@RandomByte RandomByte changed the title [FEATURE][WIP] Support writing 'bundles' config as part of a bundle [FEATURE] Support writing 'bundles' config as part of a bundle May 21, 2021
@RandomByte RandomByte requested a review from KlattG May 27, 2021 12:47
@RandomByte
Copy link
Member

Adding @KlattG for JSDoc review

Copy link
Contributor

@KlattG KlattG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few suggestions, otherwise fine.

lib/lbt/bundle/Builder.js Outdated Show resolved Hide resolved
lib/lbt/bundle/BundleDefinition.js Outdated Show resolved Hide resolved
lib/processors/bundlers/moduleBundler.js Outdated Show resolved Hide resolved
Co-authored-by: KlattG <57760635+KlattG@users.noreply.github.com>
lib/processors/bundlers/moduleBundler.js Outdated Show resolved Hide resolved
lib/processors/bundlers/moduleBundler.js Outdated Show resolved Hide resolved
lib/lbt/bundle/BundleDefinition.js Outdated Show resolved Hide resolved
svbender
svbender previously approved these changes Jun 1, 2021
Copy link
Contributor

@svbender svbender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@RandomByte RandomByte merged commit b5f372a into master Jun 1, 2021
@RandomByte RandomByte deleted the support-bundle-info-section-in-bundles branch June 1, 2021 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants