-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Support writing 'bundles' config as part of a bundle #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a bundle is created, sections can be added that will be written as sap.ui.loader.config({bundlesUI5:{...}}) information. Each section of type 'bundleInfo' represents one single bundle. The section name is the bundle name, the modules in the section are the modules of the bundle. It is currently not yet possible to reuse existing bundle definitions to define the content of such a section.
RandomByte
force-pushed
the
support-bundle-info-section-in-bundles
branch
from
May 21, 2021 09:03
5c6cff8
to
41fd727
Compare
RandomByte
changed the title
[FEATURE][WIP] Support writing 'bundles' config as part of a bundle
[FEATURE] Support writing 'bundles' config as part of a bundle
May 21, 2021
RandomByte
reviewed
May 25, 2021
…ormation for bundles configuration
Adding @KlattG for JSDoc review |
KlattG
suggested changes
May 28, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few suggestions, otherwise fine.
Co-authored-by: KlattG <57760635+KlattG@users.noreply.github.com>
codeworrior
commented
May 31, 2021
svbender
previously approved these changes
Jun 1, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
matz3
approved these changes
Jun 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a bundle is created, sections can be added that will be written as
sap.ui.loader.config({bundlesUI5:{...}}) information. Each section of
type 'bundleInfo' represents one single bundle. The section name is the
bundle name, the modules in the section are the modules of the bundle.
It is currently not yet possible to reuse existing bundle definitions to
define the content of such a section.