Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] SmartTemplateAnalyzer: Do not throw in case missing dependency is expected #479

Merged
merged 4 commits into from
Jul 21, 2020
Merged

[FIX] SmartTemplateAnalyzer: Do not throw in case missing dependency is expected #479

merged 4 commits into from
Jul 21, 2020
+132 −16

Conversation

RandomByte
Copy link
Member

@RandomByte RandomByte commented Jul 15, 2020 •
edited
Loading

In some cases it can be expected that SmartTemplateAnalyzer does not
have access to second-degree dependencies. In such cases, no error
should be thrown. Currently this causes misleading error logs, for
example in case of component preload generation for a Fiori Elements
project where no framework dependencies are available.

Resolves https://github.com/SAP/ui5-builder/issues/404

@RandomByte
[FIX] SmartTemplateAnalyzer: Do not throw in case missing dependency …
b82187f 
…is expected

In some cases it can be expected that SmartTemplateAnalyzer does not
have access to second-degree dependencies. In such cases, no error
should be thrown. Currently this causes misleading error logs, for
example in case of component preload generation for a Fiori Elements
project where no framework dependencies are available.

Resolves https://github.com/SAP/ui5-builder/issues/404
@RandomByte RandomByte force-pushed the component-preload-ignore-missing-deps branch from 835bc00 to b82187f Compare July 16, 2020 12:58
@RandomByte RandomByte changed the title WIP: SmartTemplateAnalyzer: Do not throw in cases where project dependencies might not be available [FIX] SmartTemplateAnalyzer: Do not throw in case missing dependency is expected Jul 16, 2020
@RandomByte RandomByte marked this pull request as ready for review July 16, 2020 12:59
@RandomByte RandomByte requested review from matz3 and codeworrior July 16, 2020 12:59
@coveralls
Copy link

coveralls commented Jul 16, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.02%) to 91.357% when pulling 0d148ec on component-preload-ignore-missing-deps into d18a29f on master.

@RandomByte RandomByte requested a review from matz3 July 21, 2020 08:12
matz3
matz3 previously approved these changes Jul 21, 2020
View reviewed changes
@RandomByte RandomByte merged commit b2150c3 into master Jul 21, 2020
@RandomByte RandomByte deleted the component-preload-ignore-missing-deps branch July 21, 2020 12:53
@matz3 matz3 mentioned this pull request Jul 31, 2020
Merged
matz3 added a commit that referenced this pull request Jul 31, 2020
@matz3
[FIX] generateLibraryPreload: Ignore missing modules (#481)
97b339f 
In addition to #479 the generateLibraryPreload should also ignore missing modules when creating a bundle.
As only files from the workspace are bundled, it's not a problem when dependencies can't be found. Just for self-contained bundles, this is a problem.

See: #479
@tobiasso85 tobiasso85 mentioned this pull request Aug 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matz3 matz3 matz3 approved these changes

@codeworrior codeworrior Awaiting requested review from codeworrior

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Preload building of Fiori element-based apps produce verbose log content
3 participants
@RandomByte @coveralls @matz3