[FEATURE] jsdoc: Improve support for ES6+ syntax #785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's no such thing as Syntax.OptionalMemberExpression/OptionalCallExpression, but JSDoc parser provides such "types" in case of testing. So, we need to stringify those in order to catch those cases
Some expressions might be wrappers, like ChainExpression, AwaitExpression. If we do not need to make something very specific with them, we need to resolve the underlying structures
d3xter666
changed the title
d3xter666
changed the title
d3xter666
changed the title
- only withput expression - treated like normal strings
d3xter666
changed the title
matz3
reviewed
Aug 25, 2022
matz3
reviewed
Aug 25, 2022
test/expected/build/library.j/dest/resources/library/j/dependency-es6-2.js
Outdated
Show resolved
Hide resolved
d3xter666
changed the title
matz3
requested changes
Sep 2, 2022
test/expected/build/library.j/dest/resources/library/j/dependency-es6-1.js
Outdated
Show resolved
Hide resolved
matz3
changed the title
matz3
changed the title
matz3
approved these changes
Sep 8, 2022
openui5bot
pushed a commit
to SAP/openui5
that referenced
this pull request
Oct 5, 2022
This change integrates the following Pull request from ui5-builder project: SAP/ui5-builder#785 Change-Id: I3174df8c47a95f52593d544787ee73079f99ca98
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: CPOUI5FOUNDATION-374