[FIX] manifestCreator: set fallbackLocale to empty string if no locale is present #962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flovogt
commented
Nov 27, 2023
test/expected/build/library.i/bundle-library.h-build-manifest/resources/library/i/manifest.json
Outdated
Show resolved
Hide resolved
flovogt
force-pushed
the
use-real-i18n-file-for-manifestcreator-test
branch
from
13bf726 to
7b9f870
Compare
flovogt
changed the title
flovogt
commented
Dec 7, 2023
…e is present - In case no language specific messagebundle file is present, set the fallbackLocale to empty string. - Adjust tests to use custom file instead of artifical placeholder
flovogt
force-pushed
the
use-real-i18n-file-for-manifestcreator-test
branch
from
7b9f870 to
346810c
Compare
matz3
reviewed
Dec 7, 2023
matz3
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using a artificial placeholder, you use a real message bundle file for tests.