[FIX] Resolve UI5 data directory relative to project #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The UI5 data directory (previously called UI5 home directory) should always be resolved relative to the project directory, which is where the package.json file is located at. This change also adds a list of options to the Configuration class to be used by the CLI config command to allow all available config options to be set or retrieved. Follow-up of #635
matz3
added a commit
to SAP/ui5-cli
that referenced
this pull request
Aug 18, 2023
Options are now properly read from the @ui5/project Configuration class in order to be decoupled from future changes. Some code could be removed as the checks are done via yargs. See: SAP/ui5-project#642
RandomByte
requested changes
Aug 18, 2023
matz3
added a commit
to SAP/ui5-tooling
that referenced
this pull request
Aug 18, 2023
See: SAP/ui5-project#642 JIRA: CPOUI5FOUNDATION-715
Co-authored-by: Merlin Beutlberger <m.beutlberger@sap.com>
RandomByte
approved these changes
Aug 18, 2023
matz3
added a commit
to SAP/ui5-cli
that referenced
this pull request
Aug 18, 2023
Options are now properly read from the @ui5/project Configuration class in order to be decoupled from future changes. Some code could be removed as the checks are done via yargs. See: SAP/ui5-project#642
matz3
added a commit
to SAP/ui5-cli
that referenced
this pull request
Aug 19, 2023
Options are now properly read from the @ui5/project Configuration class in order to be decoupled from future changes. Some code could be removed as the checks are done via yargs. See: SAP/ui5-project#642 JIRA: CPOUI5FOUNDATION-716 --------- Co-authored-by: Merlin Beutlberger <m.beutlberger@sap.com>
matz3
added a commit
to SAP/ui5-tooling
that referenced
this pull request
Aug 21, 2023
See: SAP/ui5-project#642 JIRA: CPOUI5FOUNDATION-715
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The UI5 data directory (previously called UI5 home directory) should
always be resolved relative to the project directory, which is where
the package.json file is located at.
This change also adds a list of options to the Configuration class to be
used by the CLI config command to allow all available config options to
be set or retrieved.
Follow-up of #635
JIRA: CPOUI5FOUNDATION-715
JIRA: CPOUI5FOUNDATION-716