Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui5-fs#235 breaks ui5-server tests #459

Closed
RandomByte opened this issue Jun 18, 2020 · 1 comment · Fixed by SAP/ui5-server#333
Closed

ui5-fs#235 breaks ui5-server tests #459

RandomByte opened this issue Jun 18, 2020 · 1 comment · Fixed by SAP/ui5-server#333
Assignees
@matz3
Labels
bug Something isn't working module/ui5-fs Related to the UI5 FS module

Comments

@RandomByte
Copy link
Member

Since SAP/ui5-fs#235 got merged, integration tests are failing due to errors in the ui5-server tests. See internal integration test run 112.

I think @matz3 suspected insufficient stubbing in those tests. So this might actually be something to be fixed in ui5-server.
@matz3 matz3 self-assigned this Jun 19, 2020
@matz3
Copy link
Member

matz3 commented Jun 19, 2020

I'll try to take care of that today

@RandomByte RandomByte transferred this issue from SAP/ui5-fs Nov 20, 2020
@RandomByte RandomByte added bug Something isn't working module/ui5-fs Related to the UI5 FS module labels Nov 20, 2020
@RandomByte RandomByte changed the title #235 breaks ui5-server tests ui5-fs#235 breaks ui5-server tests Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matz3 matz3

Labels
bug Something isn't working module/ui5-fs Related to the UI5 FS module
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[INTERNAL] serve tests fix: fs Resource#clone change SAP/ui5-server
2 participants
@matz3 @RandomByte