Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Add cli support for adding/removing ui5 dependencies to/from the package.json #631

Closed
zdravko-georgiev opened this issue Jul 1, 2022 · 4 comments
Labels
enhancement New feature or request

Comments

@zdravko-georgiev
Copy link

Is your feature request related to a problem? Please describe.

No

Describe the solution you'd like

If I want to use a custom middleware with ui5-tooling, then I need to add i to devDependencies and toui5 dependencies in the package.json, e.g.

"devDependencies": {
    "my-custom-middleware": "1",
},
"ui5": {
    "dependencies": [
        "my-custom-middleware"
    ]
}

Adding to devDependencies is done automatically by executing npm i my-custom-middleware, but the entry to ui5 dependencies needs to be done manually. It would be nice if this can be done also programmatically. E.g.
Adding

ui5 add --pkg my-custom-middleware

Removing

ui5 remove --pkg my-custom-middleware
@zdravko-georgiev zdravko-georgiev added the enhancement New feature or request label Jul 1, 2022
@cfg74
Copy link
Member

cfg74 commented Jul 1, 2022

+1

@RandomByte
Copy link
Member

Hey Zdravko, thanks for reporting. We would rather like to get rid of this workaround.

UI5 Tooling 3.0, currently available as alpha release (see https://sap.github.io/ui5-tooling/updates/migrate-v3/), will be able to reliably detect relevant modules in dependencies and devDependencies without the additional ui5 configuration. Also see SAP/ui5-project#457

Leaving this open since UI5 Tooling 3.0 is still in development and we can't provide n ETA for its release yet.

@zdravko-georgiev
Copy link
Author

Hi Merlin,
thanks for the info, I will check the links that you provided.

@flovogt
Copy link
Member

flovogt commented Feb 21, 2023

As UI5 Tooling 3.0 is released, closing this. With UI5 Tooling 3.0 it is no longer necessary to specify the devDependencies also in the ui5/dependencies section in the package.json

@flovogt flovogt closed this as completed Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants