add optional expiration date to cleezy #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added expiration date column to db table (OPTIONAL PARAMETER)
5 tasks
evanugarte
reviewed
Jun 22, 2024
modules/sqlite_helpers.py
Outdated
| @@ -17,6 +17,7 @@ def maybe_create_table(sqlite_file: str) -> bool: | |||
| url TEXT NOT NULL, | |||
| alias TEXT NOT NULL, | |||
| created_at DATETIME NOT NULL, | |||
| expiration_date DATETIME DEFAULT NULL, | |||
There was a problem hiding this comment.
can we make this the last column, right now its second to last
|
done |
evanugarte
reviewed
Jun 25, 2024
| @@ -93,7 +104,7 @@ async def get_url(alias: str): | |||
| logging.debug(f"/find called with alias: {alias}") | |||
| with MetricsHandler.query_time.labels("find").time(): | |||
| url_output = sqlite_helpers.get_url(DATABASE_FILE, alias) | |||
|
|
|||
| if response is not None: | ||
| MetricsHandler.url_count.inc(1) | ||
| return { "url": urljson['url'], "alias": alias, "created_at": response} | ||
| return { "url": urljson['url'], "alias": alias, "created_at": response, "expiration_date": expiration_date} |
There was a problem hiding this comment.
Suggested change
| return { "url": urljson['url'], "alias": alias, "created_at": response, "expiration_date": expiration_date} | |
| return return { | |
| "url": urljson['url'], | |
| "alias": alias, | |
| "created_at": response, | |
| "expiration_date": expiration_date, | |
| } |
modules/sqlite_helpers.py
Outdated
| db.commit() | ||
| return True | ||
|
|
||
| year_ago_date = current - timedelta(days=365) |
There was a problem hiding this comment.
last thing, can we remove the logic to automatically delete urls that are a year old? from now on the user will have to specify an expiration date if they want it deleted
…ttps://github.com/SCE-Development/cleezy into 33-add-an-optional-expiration-date-column-for-urls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Synchronized time formatting to '%Y-%m-%dT%H:%M:%S.
Added expiration date column to db table (OPTIONAL PARAMETER, SHOULD WORK EITHER WAY)
Auto delete on next URL request if expiration date is invalid
Some inconsistencies with timestamp formatting when I tested with Postman but I didn't know how to fix, small detail to clean up