Skip to content
This repository has been archived by the owner on May 8, 2022. It is now read-only.

Starting channel number not available for Custom Filter #33

Closed
Fyb3roptik opened this issue Apr 27, 2022 · 10 comments
Closed

Starting channel number not available for Custom Filter #33

Fyb3roptik opened this issue Apr 27, 2022 · 10 comments
Labels
enhancement New feature or request

Comments

@Fyb3roptik
Copy link

  1. Add Custom Filter
  2. Observe no way to edit Starting Number
@SCP002 SCP002 added the enhancement New feature or request label Apr 28, 2022
@SCP002 SCP002 closed this as completed in 121a9dc Apr 28, 2022
@Fyb3roptik
Copy link
Author

BTW Go dev here and I have some fixes in my repo for PPV filtering

@SCP002
Copy link
Owner

SCP002 commented Apr 28, 2022

@Fyb3roptik both of our forks has relatively large amount of code rewritten or changed and are pretty different, it's hard to just pick a change from yours without breaking something in mine 🤕

Thought maybe it's better to create a new issue here with description of a feature you would like to see in this one and I would refer to your fork to grab some code pieces (mentioning your work course!).

P.S: Will make a new build with this issue closed soon. ~ In a hour.

@Fyb3roptik
Copy link
Author

Haha yeah I'll get a PR going in your stuff. I did notice a weird issue where I couldn't edit a mapping by clicking on it

@SCP002
Copy link
Owner

SCP002 commented Apr 28, 2022

@Fyb3roptik do you mean these table rows?
sample

Weirdly on my side its working fine, maybe try with https://github.com/SCP002/xTeVe/releases/tag/2.4.1.0000 + check the browser console if it's saying something.

@Fyb3roptik
Copy link
Author

It's only when I use custom filter instead of group

@Fyb3roptik
Copy link
Author

Do you want to put this repo in a new org and possibly rebrand xteve2 or something?

@SCP002
Copy link
Owner

SCP002 commented Apr 30, 2022

TL;DR: No, don't see a reason to, but will gladly listen to people's arguments, so I could if you want.

My roadmap is to, well, close these three: #35 #36 #38 (this one half done ATM, at least it looks like it is 🙃), in a next few days (depending on my free time etc.), upload the final release and archive this repository, because soon I'll switch to another project and it would be unfair to let people waste time on submitting new issues etc. which I'll never touch in the future ( ._.)

Why so:
Forgive me people, but after I close these three, my own usecase will be covered with xTeVe's current functionality and to be honest, I dont really want to become a new day-to-day maintainer of this project.

P.S: Forgive my English.

@Fyb3roptik
Copy link
Author

Would you mind if after that happens I fork it into its own project? Obviously would have all credits in place

@SCP002
Copy link
Owner

SCP002 commented May 3, 2022

Sure! Moreover, credits are not mandatory: you are completely free to do whatever you want to do :)

@Fyb3roptik
Copy link
Author

No sir! I give credit where it's due! That's what makes this community great!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants