Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove old builds from memory #7

Open
TheJJ opened this issue Jul 18, 2016 · 1 comment
Open

remove old builds from memory #7

TheJJ opened this issue Jul 18, 2016 · 1 comment

Comments

@TheJJ
Copy link
Member

TheJJ commented Jul 18, 2016

all builds are stored on disk anyway, but we should drop old builds from ram.
this can prevent denial of service attacks where all builds for projects are walked through and requested, thereby loaded from disk into ram. for many builds, this can exhaust memory of the process.

-> keep a maximum of $n builds in memory, delete more.

@TheJJ
Copy link
Member Author

TheJJ commented Apr 21, 2017

We now have the BuildManager for that. It still doesn't delete old builds from memory, but it could easily do that now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant