Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modularize update_deps.py further #148

Closed
CasperWA opened this issue May 12, 2023 · 1 comment
Closed

Modularize update_deps.py further #148

CasperWA opened this issue May 12, 2023 · 1 comment
Labels
enhancement New feature or request priority/low Low priority issue/PR

Comments

@CasperWA
Copy link
Collaborator

This looks good although update_deps.py is (in my opinion) too long to understand and review efficiently. Perhaps it could be worth to clarify its central operational loop and move the logic functions into one or more separate files?

Originally posted by @ajeklund in #140 (review)
@CasperWA CasperWA added enhancement New feature or request priority/low Low priority issue/PR labels May 12, 2023
@CasperWA CasperWA mentioned this issue May 12, 2023
Merged
@CasperWA
Copy link
Collaborator Author

I consider this done by the recently merged #190

@CasperWA CasperWA mentioned this issue Nov 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request priority/low Low priority issue/PR
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@CasperWA