Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-commit for documentation not working on windows #160

Closed
sygout opened this issue Jul 10, 2023 · 3 comments · Fixed by #165
Closed

Pre-commit for documentation not working on windows #160

sygout opened this issue Jul 10, 2023 · 3 comments · Fixed by #165
Assignees
Labels
bug Something isn't working pre-commit hooks Issue/PR related to pre-commit hooks priority/high High priority issue/PR

Comments

@sygout
Copy link
Contributor

sygout commented Jul 10, 2023

due to a at least dependency on "grep", "sed" command the pre-commit is not working on windows

@sygout sygout added bug Something isn't working pre-commit hooks Issue/PR related to pre-commit hooks priority/high High priority issue/PR labels Jul 10, 2023
@CasperWA CasperWA self-assigned this Aug 21, 2023
@CasperWA
Copy link
Collaborator

Do you have a link to a workflow run that uses a callable workflow from this library as an example of this issue?

@CasperWA
Copy link
Collaborator

After some discussions elsewhere I think to have located the issue. It has to do with the linux commands used in the pre-commit hooks - not the callable workflows (which all run in a unix environment).

@CasperWA
Copy link
Collaborator

I can't reproduce this issue in the CI environments. I have tried several approaches (running the pre-commit commands through a Python script using subprocess.run() with shell=True, but also just running the pre-commit commands straight up in the CI jobs using the cmd shell).
See for example this run.

It is difficult for me to make sure I completely fix the issue if I cannot test it subsequently. Hence, could you please provide a reproducible example that triggers this issue/bug as well as perhaps some system information?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pre-commit hooks Issue/PR related to pre-commit hooks priority/high High priority issue/PR
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants