Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show username when logged in #125

Closed
2 of 3 tasks
williamlixu opened this issue Mar 20, 2020 · 0 comments · Fixed by #146
Closed
2 of 3 tasks

Show username when logged in #125

williamlixu opened this issue Mar 20, 2020 · 0 comments · Fixed by #146
Assignees
@andrewh318
Labels
approved Issue has been approved by PM back-end Issues related to back-end development front-end Issues related to front-end development good first issue Good for newcomers

Comments

@williamlixu
Copy link
Collaborator

williamlixu commented Mar 20, 2020 •
edited by tyger-kong
Loading

User Story
For example:
As a user
I want to know I am logged in and see my username
So using Split is nicer and easier

Priority

  • High
  • Medium
  • Low

Describe the solution you want to implement

  • Backend pass a cookie back after successful login.
  • Frontend uses cookie and passes information into component to be displayed
  • Throw away cookie on logout

Describe alternatives you've considered

  1. Passing username from BE to FE after successful login
  2. Grab username from login field

Issue Dependencies
n/a

Additional context
Currently the name in the top bar is hard-coded to "David Dollar".
@williamlixu williamlixu added good first issue Good for newcomers front-end Issues related to front-end development labels Mar 20, 2020
@tyger-kong tyger-kong added the back-end Issues related to back-end development label Apr 7, 2020
@kaplunket kaplunket added the approved Issue has been approved by PM label Apr 7, 2020
@andrewh318 andrewh318 self-assigned this Apr 12, 2020
@andrewh318 andrewh318 mentioned this issue Apr 13, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrewh318 andrewh318

Labels
approved Issue has been approved by PM back-end Issues related to back-end development front-end Issues related to front-end development good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/show username when logged in andrewh318/A2
4 participants
@andrewh318 @tyger-kong @williamlixu @kaplunket