Supporting WSL by enabling optional default Database constructors

[Naville]

I currently uses the following CMake:

# Detecting WSL
IF(EXISTS "/proc/version")
  file(READ "/proc/version" PROC_VERSION)
  string(FIND "${PROC_VERSION}" "Microsoft" PROC_VERSION_IS_MS)
  if(NOT "${PROC_VERSION_IS_MS}" MATCHES "-1")
      message("WSL Detected. Using workaround for broken fcntl")
      add_compile_definitions("USING_WSL")
  endif()
ENDIF()

and

#ifdef USING_WSL
  Database DB(DBPath,SQLite::OPEN_READWRITE | OPEN_CREATE,"unix-dotfile");
#else
  Database DB(DBPath, SQLite::OPEN_READWRITE | OPEN_CREATE);
#endif

To workaround the lack of fcntl support on Windows WSL. I figured if this could be tested and probably merged into the main project

[SRombauts]

Hi, can you tell le what is not working correctly une Windows Subsystem for Linux ?
I was under thé impression that is was working correctly, with all unit tests passing.

What change to the Database constructor are you proposing?

Cheers !

[Naville]

@SRombauts See microsoft/WSL#2395 and its comments, better than my own words

[Naville]

What change to the Database constructor are you proposing?

I was hoping that the aVfs argument here defaults to "unix-dotfile" on WSL so library users dont have to explicitly deal with this

SQLiteCpp/include/SQLiteCpp/Database.h

Line 146 in be1a8ee

const std::string& aVfs = "") :

Although I'll admit I'm an idiot on SQL stuff so this might not be the perfect solution here

[SRombauts]

Ah yes, I see !
Let me see how to reproduce the issue first