Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update react and react-dom versions #140

Merged
merged 1 commit into from
Nov 7, 2020
Merged

Conversation

shawnmcknight
Copy link
Owner

Description 📝

Update peerDependencies to support react ^17.0.1 alongside ^16.8.0 and update devDependencies for react and react-dom to ^17.0.1.

Note: I attempted to update everything to make use of the new jsx transform but it appears that this would be a breaking change that prevented v16 of React from working. Once v16 support gets deprecated from this repo it can be revisited.

Relevant issues 🎯

N/A

Type of change 💎

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested? 🚦

CI passes. Tested locally using example within repo as well as from an external repo on both React 16.13.x and 17.0.1.

Checklist 🏁

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • New and existing unit tests pass locally with my changes
  • My changes pass lint, prettier, and TS checks
  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas

@shawnmcknight shawnmcknight merged commit 9b80451 into master Nov 7, 2020
@shawnmcknight shawnmcknight deleted the update-react-17 branch November 7, 2020 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant