vt doc: Improve libvirt network section #610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
BTW, this change was inspired by https://bugzilla.suse.com/show_bug.cgi?id=1166570 |
jfehlig
force-pushed
the
libvirt-network-fixes
branch
2 times, most recently
from
6e050ce to
4593e6b
Compare
|
After some conversations with Marius, I've force pushed some improvements to the improvements. |
hw-claudio
reviewed
Jun 18, 2020
hw-claudio
reviewed
Jun 18, 2020
hw-claudio
reviewed
Jun 18, 2020
jfehlig
force-pushed
the
libvirt-network-fixes
branch
from
4593e6b to
0d6b602
Compare
|
Ok, another attempt and another force push. Claudio mentioned some pictures would help, e.g. similar to the ones on the libvirt wiki https://wiki.libvirt.org/page/VirtualNetworking What do the doc folks think about that? |
lproven
suggested changes
Jun 19, 2020
jfehlig
force-pushed
the
libvirt-network-fixes
branch
3 times, most recently
from
6e58f01 to
a03887d
Compare
hw-claudio
reviewed
Jun 22, 2020
An out-of-the-box configuration of SLES with KVM or Xen provides a wicked-managed, L2 bridge configuration for VM connectivity. libvirt virtual networks provide an alternate network setup for VM connectivity but must be enabled separately. Since the wicked-managed configuration is the default, move it's description before that of libvirt's virtual networks. Also remove the confusing text around isolated vs forwarded networks and add some information about use-cases for the various configurations. Finally, add a warning about the implicit enabling of layer 3 forwarding in the VM host when enabling a libvirt virtual network. See https://bugzilla.suse.com/show_bug.cgi?id=1166570 for more details.
jfehlig
force-pushed
the
libvirt-network-fixes
branch
from
a03887d to
a4fd402
Compare
tbazant
pushed a commit
that referenced
this pull request
Jun 24, 2020
An out-of-the-box configuration of SLES with KVM or Xen provides a wicked-managed, L2 bridge configuration for VM connectivity. libvirt virtual networks provide an alternate network setup for VM connectivity but must be enabled separately. Since the wicked-managed configuration is the default, move it's description before that of libvirt's virtual networks. Also remove the confusing text around isolated vs forwarded networks and add some information about use-cases for the various configurations. Finally, add a warning about the implicit enabling of layer 3 forwarding in the VM host when enabling a libvirt virtual network. See https://bugzilla.suse.com/show_bug.cgi?id=1166570 for more details.
tbazant
added a commit
that referenced
this pull request
Jun 24, 2020
|
I thought there were gate checks to verify a PR could be built. Such trivial and common mistakes could be automatically detected well before merging. |
There are. Or, rather, there are meant to be. This highlighted a bug in DAPS which caused it to return the wrong exit code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a warning about enabling forwarding in the VM host when enabling
a libvirt virtual network. While at it, make some small improvements
in the description of libvirt's virtual networks.
Are backports required?