From 47988ffff166eb859d77f398cb522c1497962612 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Danilo=20B=C3=BCrger?= Date: Wed, 23 Mar 2022 05:03:56 -0700 Subject: [PATCH] Remove Gemfile.lock from template (#33469) Summary: For the same reason we don't keep a yarn.lock or Podfile.lock, we shouldn't be keeping a Gemfile.lock in the template. The user will generate this on his own pulling in the current dependencies with the constraints in Gemfile. No need to lock to a specific version. cc barbieri (author of https://github.com/facebook/react-native/pull/32303) cc ravirajn22 (for raising the issue) [iOS] [Fixed] - Remove Gemfile.lock from template Pull Request resolved: https://github.com/facebook/react-native/pull/33469 Test Plan: no test plan Reviewed By: javache Differential Revision: D35074105 Pulled By: cortinico fbshipit-source-id: 47d1b92329f1d55d4a0adbacbc7e5e45f9d957e0 --- scripts/update-ruby.sh | 6 +-- template/Gemfile.lock | 102 ----------------------------------------- 2 files changed, 2 insertions(+), 106 deletions(-) delete mode 100644 template/Gemfile.lock diff --git a/scripts/update-ruby.sh b/scripts/update-ruby.sh index 37aaf5f46dea06..9b5273d6dc161b 100755 --- a/scripts/update-ruby.sh +++ b/scripts/update-ruby.sh @@ -53,17 +53,15 @@ echo "$VERSION" > template/_ruby-version sed_i -e "s/^\(ruby '\)[^']*\('.*\)$/\1$VERSION\2/" Gemfile sed_i -e "s/^\(ruby '\)[^']*\('.*\)$/\1$VERSION\2/" template/Gemfile -rm -f Gemfile.lock template/Gemfile.lock +rm -f Gemfile.lock export BUNDLE_APP_CONFIG="$ROOT/.bundle" cp "$BUNDLE_APP_CONFIG/"* template/_bundle # sync! bundle lock -(cd template && bundle lock) git add \ .ruby-version \ Gemfile \ template/_ruby-version \ - template/Gemfile \ - template/Gemfile.lock + template/Gemfile diff --git a/template/Gemfile.lock b/template/Gemfile.lock deleted file mode 100644 index 7a915c204418b2..00000000000000 --- a/template/Gemfile.lock +++ /dev/null @@ -1,102 +0,0 @@ -GEM - remote: https://rubygems.org/ - specs: - CFPropertyList (3.0.4) - rexml - activesupport (6.1.4.1) - concurrent-ruby (~> 1.0, >= 1.0.2) - i18n (>= 1.6, < 2) - minitest (>= 5.1) - tzinfo (~> 2.0) - zeitwerk (~> 2.3) - addressable (2.8.0) - public_suffix (>= 2.0.2, < 5.0) - algoliasearch (1.27.5) - httpclient (~> 2.8, >= 2.8.3) - json (>= 1.5.1) - atomos (0.1.3) - claide (1.0.3) - cocoapods (1.11.2) - addressable (~> 2.8) - claide (>= 1.0.2, < 2.0) - cocoapods-core (= 1.11.2) - cocoapods-deintegrate (>= 1.0.3, < 2.0) - cocoapods-downloader (>= 1.4.0, < 2.0) - cocoapods-plugins (>= 1.0.0, < 2.0) - cocoapods-search (>= 1.0.0, < 2.0) - cocoapods-trunk (>= 1.4.0, < 2.0) - cocoapods-try (>= 1.1.0, < 2.0) - colored2 (~> 3.1) - escape (~> 0.0.4) - fourflusher (>= 2.3.0, < 3.0) - gh_inspector (~> 1.0) - molinillo (~> 0.8.0) - nap (~> 1.0) - ruby-macho (>= 1.0, < 3.0) - xcodeproj (>= 1.21.0, < 2.0) - cocoapods-core (1.11.2) - activesupport (>= 5.0, < 7) - addressable (~> 2.8) - algoliasearch (~> 1.0) - concurrent-ruby (~> 1.1) - fuzzy_match (~> 2.0.4) - nap (~> 1.0) - netrc (~> 0.11) - public_suffix (~> 4.0) - typhoeus (~> 1.0) - cocoapods-deintegrate (1.0.5) - cocoapods-downloader (1.6.3) - cocoapods-plugins (1.0.0) - nap - cocoapods-search (1.0.1) - cocoapods-trunk (1.6.0) - nap (>= 0.8, < 2.0) - netrc (~> 0.11) - cocoapods-try (1.2.0) - colored2 (3.1.2) - concurrent-ruby (1.1.9) - escape (0.0.4) - ethon (0.15.0) - ffi (>= 1.15.0) - ffi (1.15.4) - fourflusher (2.3.1) - fuzzy_match (2.0.4) - gh_inspector (1.1.3) - httpclient (2.8.3) - i18n (1.8.10) - concurrent-ruby (~> 1.0) - json (2.6.0) - minitest (5.14.4) - molinillo (0.8.0) - nanaimo (0.3.0) - nap (1.1.0) - netrc (0.11.0) - public_suffix (4.0.6) - rexml (3.2.5) - ruby-macho (2.5.1) - typhoeus (1.4.0) - ethon (>= 0.9.0) - tzinfo (2.0.4) - concurrent-ruby (~> 1.0) - xcodeproj (1.21.0) - CFPropertyList (>= 2.3.3, < 4.0) - atomos (~> 0.1.3) - claide (>= 1.0.2, < 2.0) - colored2 (~> 3.1) - nanaimo (~> 0.3.0) - rexml (~> 3.2.4) - zeitwerk (2.5.1) - -PLATFORMS - arm64-darwin-20 - ruby - x86_64-linux - -DEPENDENCIES - cocoapods (~> 1.11, >= 1.11.2) - -RUBY VERSION - ruby 2.7.5p203 - -BUNDLED WITH - 2.3.14