Skip to content
This repository has been archived by the owner on Nov 29, 2023. It is now read-only.

Implementation of boundary annotations should allow for none #768

Closed
GideonKoenig opened this issue Jun 24, 2022 · 2 comments
Closed

Implementation of boundary annotations should allow for none #768

GideonKoenig opened this issue Jun 24, 2022 · 2 comments
Labels
@boundary Related to the @boundary annotation duplicate This issue or pull request already exists enhancement 💡 New feature or request

Comments

@GideonKoenig
Copy link
Contributor

Is your feature request related to a problem?

Currently a parameter that has a boundary annotation set, does not allow none as value. Sometimes there are valid intervals specified for parameters that could be used.

Desired solution

In the Interface there should be a checkbox that can be checked, to signal, that none is allowed.
In the automatic generation, you can check, if the type contains none which would imply, that none should be allowed.
In the implementation of the boundary annotation wrapper, these changes need to be implemented as well.

This issue is kind of similar to Safe-DS/Library-Analyzer#36

Possible alternatives (optional)

Just don't automatically set boundary annotations for parameters that allow none as value.

Screenshots (optional)

No response

Additional Context (optional)

No response

@GideonKoenig GideonKoenig added the enhancement 💡 New feature or request label Jun 24, 2022
@lars-reimann lars-reimann added the @boundary Related to the @boundary annotation label Jun 25, 2022
@GideonKoenig
Copy link
Contributor Author

GideonKoenig commented Jul 1, 2022

Maybe it would make more sense, to change the implementation of the boundary annotation, to check if the provided value is of the type that the boundary is associated with (Integer or float).
This way boundary annotations could be easily set even as part of broader sets of allowed types or be stacked on top of each other (for different types - see Safe-DS/Library-Analyzer#36).

@GideonKoenig
Copy link
Contributor Author

This issue will be solved by Safe-DS/Library-Analyzer#36 and is now redundant.

@lars-reimann lars-reimann added the duplicate This issue or pull request already exists label Jul 10, 2022
@lars-reimann lars-reimann closed this as not planned Won't fix, can't repro, duplicate, stale Jul 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
@boundary Related to the @boundary annotation duplicate This issue or pull request already exists enhancement 💡 New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants