From 6839ae9334e71bfa37a8965b68fd2332de4e804f Mon Sep 17 00:00:00 2001 From: Jonas B Date: Sat, 22 Jun 2024 03:09:06 +0200 Subject: [PATCH] refactor: linter --- packages/safe-ds-eda/src/apis/extensionApi.ts | 2 +- packages/safe-ds-eda/src/components/TableView.svelte | 3 --- .../src/components/column-filters/ColumnFilters.svelte | 6 +++--- 3 files changed, 4 insertions(+), 7 deletions(-) diff --git a/packages/safe-ds-eda/src/apis/extensionApi.ts b/packages/safe-ds-eda/src/apis/extensionApi.ts index fbd196f57..bba9d5e25 100644 --- a/packages/safe-ds-eda/src/apis/extensionApi.ts +++ b/packages/safe-ds-eda/src/apis/extensionApi.ts @@ -1,6 +1,6 @@ import { get } from 'svelte/store'; import type { HistoryEntry } from '../../types/state'; -import { profilingLoading, table, history, tableLoading } from '../webviewState'; +import { profilingLoading, table, history } from '../webviewState'; import type { ExecuteRunnerAllEntry } from '../../types/messaging'; import { filterHistoryOnlyInternal } from './historyApi'; diff --git a/packages/safe-ds-eda/src/components/TableView.svelte b/packages/safe-ds-eda/src/components/TableView.svelte index 8162f2c6a..692ff97e2 100644 --- a/packages/safe-ds-eda/src/components/TableView.svelte +++ b/packages/safe-ds-eda/src/components/TableView.svelte @@ -10,7 +10,6 @@ possibleColumnFilters, profilingOutdated, history, - profilingLoading, } from '../webviewState'; import CaretIcon from '../icons/Caret.svelte'; import ErrorIcon from '../icons/Error.svelte'; @@ -18,11 +17,9 @@ import type { Column, OneColumnTabTypes, - PossibleColumnFilter, PossibleSorts, Profiling, ProfilingDetail, - ProfilingDetailStatistical, TwoColumnTabTypes, } from '../../types/state.js'; import ProfilingInfo from './profiling/ProfilingInfo.svelte'; diff --git a/packages/safe-ds-eda/src/components/column-filters/ColumnFilters.svelte b/packages/safe-ds-eda/src/components/column-filters/ColumnFilters.svelte index 216a6b1b2..aceb87a1d 100644 --- a/packages/safe-ds-eda/src/components/column-filters/ColumnFilters.svelte +++ b/packages/safe-ds-eda/src/components/column-filters/ColumnFilters.svelte @@ -114,7 +114,7 @@ }; const confirmValueRangeFilter = (totalMin: number, totalMax: number) => { - if (minValue == null || maxValue == null) return; + if (minValue === null || maxValue === null) return; if (isInvalidRange(minValue, maxValue, totalMin, totalMax)) return; if (minValue === totalMin && maxValue === totalMax) { @@ -146,8 +146,8 @@ selectDone(); }; - const isInvalidRange = (minValue: number, maxValue: number, totalMin: number, totalMax: number) => { - return minValue >= maxValue || minValue < totalMin || maxValue > totalMax; + const isInvalidRange = (minValueNow: number, maxValueNow: number, totalMin: number, totalMax: number) => { + return minValueNow >= maxValueNow || minValueNow < totalMin || maxValueNow > totalMax; }; const removeFilters = () => {