Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add moving average plot #521

Closed
Tracked by #517
Gerhardsa0 opened this issue Jan 10, 2024 · 4 comments · Fixed by #836
Closed
Tracked by #517

feat: Add moving average plot #521

Gerhardsa0 opened this issue Jan 10, 2024 · 4 comments · Fixed by #836
Assignees
Labels
enhancement 💡 New feature or request

Comments

@Gerhardsa0
Copy link
Contributor

Gerhardsa0 commented Jan 10, 2024

Is your feature request related to a problem?

The user should be able to see the moving average in context with the time series.

Desired solution

The user should just call something like this: ts.plot_movingaverage()
When implementing this, the pandas df.roll-function could be pretty useful.

https://pandas.pydata.org/docs/reference/api/pandas.DataFrame.rolling.html

@Gerhardsa0 Gerhardsa0 added the enhancement 💡 New feature or request label Jan 10, 2024
@Gerhardsa0 Gerhardsa0 linked a pull request Feb 21, 2024 that will close this issue
@Gerhardsa0 Gerhardsa0 self-assigned this Jun 10, 2024
@Gerhardsa0
Copy link
Contributor Author

@lars-reimann
for the implementation I could use this function: https://docs.pola.rs/api/python/stable/reference/expressions/api/polars.Expr.rolling_mean.html

But it's considered unstable, so should I use this function, or write an own rolling average?

@lars-reimann
Copy link
Member

Use the polars version. If they change it, we change the implementation of our wrapper.

@Gerhardsa0
Copy link
Contributor Author

Should there also be an moving average function for a Column, which calculates the moving average and returns it as a column.
The same goes for windows.

@Gerhardsa0 Gerhardsa0 linked a pull request Jun 11, 2024 that will close this issue
@lars-reimann
Copy link
Member

Maybe later, you don't have to worry about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 💡 New feature or request
Projects
Status: ✔️ Done
Development

Successfully merging a pull request may close this issue.

2 participants