Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let the person know which request was canceled #52

Open
Salz0 opened this issue Oct 30, 2023 · 7 comments
Open

Let the person know which request was canceled #52

Salz0 opened this issue Oct 30, 2023 · 7 comments
Assignees
Labels

Comments

@Salz0
Copy link
Owner

Salz0 commented Oct 30, 2023

What's happening?

Currently the bot simply types the cancelation message without any reference to the request

Why?

It should be more intuitive to do a bot.reply() instead of bot.send_message() because the person will understand what is happening

This is easy to fix

@sfazli96
Copy link
Contributor

I just want to make sure the fix should be bot.reply() where the bot replies instead of it sending a message? So the fix is I would change it in the file somewhere, correct? I can give this issue a try.

@mykolasolodukha
Copy link
Collaborator

@Salz0 bot.reply() implies that we already have message_id somewhere saved (either locally or in the database). Is that the case or is it irrelevant?

@mykolasolodukha
Copy link
Collaborator

@sfazli96 feel free to give it a go. If anything, we're here to help 🙂

@Salz0
Copy link
Owner Author

Salz0 commented Oct 31, 2023

@Salz0 bot.reply() implies that we already have message_id somewhere saved (either locally or in the database). Is that the case or is it irrelevant?

The cancelation button should include the message_id. That way it should be good

@Salz0
Copy link
Owner Author

Salz0 commented Oct 31, 2023

@Salz0 bot.reply() implies that we already have message_id somewhere saved (either locally or in the database). Is that the case or is it irrelevant?

The cancelation button should include the message_id. That way it should be good

@sfazli96 @mykolasolodukha

@Khoinguyen898
Copy link

Hi maintainer, can I please be assigned this issue ? Mainly because I am looking to further expand my Open Source Portfolio in Python so I thought this would be a great place to start, thank you in advanced

@Salz0
Copy link
Owner Author

Salz0 commented Dec 18, 2024

Hi maintainer, can I please be assigned this issue ? Mainly because I am looking to further expand my Open Source Portfolio in Python so I thought this would be a great place to start, thank you in advanced

Sure! Waiting for your pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants