Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: Reuse last mask #209

Closed
JenXIII opened this issue Feb 12, 2023 · 4 comments
Closed

FR: Reuse last mask #209

JenXIII opened this issue Feb 12, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@JenXIII
Copy link

JenXIII commented Feb 12, 2023

In a lot of cases I find that it's at first unclear which method/settings is best to apply to a certain image+mask, so I find myself needing to reenter the mask fairly often to try various approaches.

Also, there can be cases where a second application is needed (with a different method, or just to clean up artifacts left by the first pass) and the first mask will suffice for the second step.

To better facilitate these two use cases, it would be nice if there was a button and/or hotkey in the UI to allow applying the last mask used with the current image & settings.

@Fenrir200678
Copy link

+1 on that. Was about to open the same feature request. :)

@Sanster
Copy link
Owner

Sanster commented Feb 14, 2023

This can be achieved by the following operations, although it does a little bit 🤏complicated

  1. Prepare a mask

Enable download mask in settings, when clicking the download button, you will get a mask. Or you can also prepare a mask by yourself.

image

  1. Upload the mask and run different models. (click the image to see example video)

Watch the video

@JenXIII
Copy link
Author

JenXIII commented Feb 14, 2023

I am aware it is possible to do things like this. However workflow-wise it is not very ideal.

Usually, a mask is only needed once if I am good at predicting which method/settings are needed, and/or the task is simple. However, in the case the cleaning is not as intended, then I may need that mask I just made again, except it is now gone and I must remake it.

The workaround for this would be to just save EVERY mask I make, since I do not necessarily know which ones will need reuse. However, since most masks are not useful after their first application, this leads to wasted time/space in dealing up with extraneous mask files. Also, it is kind of clunky to have to go and select it from a system dialogue rather than just hit a "reuse previous mask" button.

@Sanster Sanster added the enhancement New feature or request label Feb 14, 2023
@Sanster
Copy link
Owner

Sanster commented Feb 19, 2023

@Sanster Sanster closed this as completed Feb 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants