From d460b6cfcf98a29e4f22acc308701aadff4e3365 Mon Sep 17 00:00:00 2001 From: eriwarr Date: Wed, 17 Jul 2024 13:43:57 -0500 Subject: [PATCH 1/9] Add GitHub Action for Biome Check --- .github/workflows/biomeCheck.yml | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) create mode 100644 .github/workflows/biomeCheck.yml diff --git a/.github/workflows/biomeCheck.yml b/.github/workflows/biomeCheck.yml new file mode 100644 index 0000000000..3ec7ffe562 --- /dev/null +++ b/.github/workflows/biomeCheck.yml @@ -0,0 +1,30 @@ +name: Biome Check + +on: + push: + branches: + - main + - 'release/*' + pull_request: + branches: + - main + - 'release/*' + +jobs: + biome-check: + runs-on: ubuntu-latest + + steps: + - name: Checkout repository + uses: actions/checkout@v3 + + - name: Set up Node.js + uses: actions/setup-node@v3 + with: + node-version: '16' # Specify the Node.js version you use + + - name: Install dependencies + run: npm install + + - name: Run Biome Check + run: npx biome check --settings ./.biome/settings.json \ No newline at end of file From c4bc90478331f7ddb21bcaedb9b7c2aa9c9ba63a Mon Sep 17 00:00:00 2001 From: eriwarr Date: Wed, 17 Jul 2024 13:46:59 -0500 Subject: [PATCH 2/9] editing yml file --- .github/workflows/biomeCheck.yml | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/.github/workflows/biomeCheck.yml b/.github/workflows/biomeCheck.yml index 3ec7ffe562..73b1c54caf 100644 --- a/.github/workflows/biomeCheck.yml +++ b/.github/workflows/biomeCheck.yml @@ -2,13 +2,7 @@ name: Biome Check on: push: - branches: - - main - - 'release/*' - pull_request: - branches: - - main - - 'release/*' + branches: [main] jobs: biome-check: From 79fc117ce45e200298f3aae3c57f005bde8b77a4 Mon Sep 17 00:00:00 2001 From: eriwarr Date: Wed, 17 Jul 2024 13:57:57 -0500 Subject: [PATCH 3/9] updating biome file --- .github/workflows/biomeCheck.yml | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/.github/workflows/biomeCheck.yml b/.github/workflows/biomeCheck.yml index 73b1c54caf..3a659ffecf 100644 --- a/.github/workflows/biomeCheck.yml +++ b/.github/workflows/biomeCheck.yml @@ -1,21 +1,26 @@ name: Biome Check on: - push: - branches: [main] + push: + branches: + - main + pull_request: + branches: + - main + workflow_dispatch: jobs: biome-check: runs-on: ubuntu-latest steps: - - name: Checkout repository - uses: actions/checkout@v3 + - name: Checkout Out Code + uses: actions/checkout@v4 - name: Set up Node.js - uses: actions/setup-node@v3 + uses: actions/setup-node@v4 with: - node-version: '16' # Specify the Node.js version you use + node-version-file: frontend/package.json - name: Install dependencies run: npm install From 817bba66d0f789458ea6db00866323a4453d160a Mon Sep 17 00:00:00 2001 From: eriwarr Date: Wed, 17 Jul 2024 14:02:17 -0500 Subject: [PATCH 4/9] testing --- .github/workflows/biomeCheck.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/biomeCheck.yml b/.github/workflows/biomeCheck.yml index 3a659ffecf..2972f3dae0 100644 --- a/.github/workflows/biomeCheck.yml +++ b/.github/workflows/biomeCheck.yml @@ -23,7 +23,7 @@ jobs: node-version-file: frontend/package.json - name: Install dependencies - run: npm install + run: npm ci - name: Run Biome Check run: npx biome check --settings ./.biome/settings.json \ No newline at end of file From 2bf4896da3c51825c77d49845232e3facc2b8dbb Mon Sep 17 00:00:00 2001 From: eriwarr Date: Wed, 17 Jul 2024 14:05:12 -0500 Subject: [PATCH 5/9] updating job --- .github/workflows/biomeCheck.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/biomeCheck.yml b/.github/workflows/biomeCheck.yml index 2972f3dae0..f0046aae3f 100644 --- a/.github/workflows/biomeCheck.yml +++ b/.github/workflows/biomeCheck.yml @@ -21,6 +21,8 @@ jobs: uses: actions/setup-node@v4 with: node-version-file: frontend/package.json + cache: 'npm' + cache-dependency-path: frontend/package-lock.json - name: Install dependencies run: npm ci From 58d5efc41410f58b81fd90391cc350497b633c62 Mon Sep 17 00:00:00 2001 From: eriwarr Date: Wed, 17 Jul 2024 14:08:42 -0500 Subject: [PATCH 6/9] removing biome yml file --- .github/workflows/biomeCheck.yml | 31 -------------------------- .github/workflows/runFrontendTests.yml | 2 ++ 2 files changed, 2 insertions(+), 31 deletions(-) delete mode 100644 .github/workflows/biomeCheck.yml diff --git a/.github/workflows/biomeCheck.yml b/.github/workflows/biomeCheck.yml deleted file mode 100644 index f0046aae3f..0000000000 --- a/.github/workflows/biomeCheck.yml +++ /dev/null @@ -1,31 +0,0 @@ -name: Biome Check - -on: - push: - branches: - - main - pull_request: - branches: - - main - workflow_dispatch: - -jobs: - biome-check: - runs-on: ubuntu-latest - - steps: - - name: Checkout Out Code - uses: actions/checkout@v4 - - - name: Set up Node.js - uses: actions/setup-node@v4 - with: - node-version-file: frontend/package.json - cache: 'npm' - cache-dependency-path: frontend/package-lock.json - - - name: Install dependencies - run: npm ci - - - name: Run Biome Check - run: npx biome check --settings ./.biome/settings.json \ No newline at end of file diff --git a/.github/workflows/runFrontendTests.yml b/.github/workflows/runFrontendTests.yml index 31347d76e6..0b93e5545c 100644 --- a/.github/workflows/runFrontendTests.yml +++ b/.github/workflows/runFrontendTests.yml @@ -50,6 +50,8 @@ jobs: run: npm ci - name: Run Vitest unit tests run: npm test + - name: Run Biome Check + run: npx biome check --settings ./.biome/settings.json # If it's a PR creation or update, we'll run the e2e test here on Netlify # if it's a merge to main, the E2E will run in e2eStaging.yml From 52d941c2405c3b20b08456b6185f3030852ab137 Mon Sep 17 00:00:00 2001 From: eriwarr Date: Wed, 17 Jul 2024 14:14:26 -0500 Subject: [PATCH 7/9] adds biome file bck --- .github/workflows/biomeCheck.yml | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) create mode 100644 .github/workflows/biomeCheck.yml diff --git a/.github/workflows/biomeCheck.yml b/.github/workflows/biomeCheck.yml new file mode 100644 index 0000000000..0fa5f275dd --- /dev/null +++ b/.github/workflows/biomeCheck.yml @@ -0,0 +1,22 @@ +name: Biome Check + +on: + push: + branches: [main] + pull_request: + branches: [main] + +jobs: + check_biome: + name: Checks Biome + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v4 + - uses: actions/setup-node@v4 + with: + node-version-file: frontend/package.json + cache: 'npm' + cache-dependency-path: frontend/package-lock.json + - name: Install dependencies + run: npm ci + From 50bbbe26c6ad2e528a1972b82cc61d911103631e Mon Sep 17 00:00:00 2001 From: eriwarr Date: Wed, 17 Jul 2024 14:19:20 -0500 Subject: [PATCH 8/9] add more args --- .github/workflows/biomeCheck.yml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.github/workflows/biomeCheck.yml b/.github/workflows/biomeCheck.yml index 0fa5f275dd..e422a04114 100644 --- a/.github/workflows/biomeCheck.yml +++ b/.github/workflows/biomeCheck.yml @@ -5,6 +5,11 @@ on: branches: [main] pull_request: branches: [main] + paths: + - 'frontend/**' +defaults: + run: + working-directory: frontend jobs: check_biome: From 7f108c4b7d7b7b3db2129f3cdfb4cc843ca63f1a Mon Sep 17 00:00:00 2001 From: Eric M Warren II Date: Wed, 17 Jul 2024 14:23:01 -0500 Subject: [PATCH 9/9] Update runFrontendTests.yml --- .github/workflows/runFrontendTests.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/runFrontendTests.yml b/.github/workflows/runFrontendTests.yml index 0b93e5545c..31347d76e6 100644 --- a/.github/workflows/runFrontendTests.yml +++ b/.github/workflows/runFrontendTests.yml @@ -50,8 +50,6 @@ jobs: run: npm ci - name: Run Vitest unit tests run: npm test - - name: Run Biome Check - run: npx biome check --settings ./.biome/settings.json # If it's a PR creation or update, we'll run the e2e test here on Netlify # if it's a merge to main, the E2E will run in e2eStaging.yml