[py3.6] TypeError: write() argument must be str, not bytes

[rplevka]

TypeError: write() argument must be str, not bytes

tests.foreman.api.test_repository/RepositoryTestCase/test_positive_access_protected_repository

[ldjebran]

@rplevka The returned certificate from nailgun is byte in py3, so perhaps we have to update the nailgun download_debug_certificate to always return str

[rplevka]

@ldjebran yeah, thanks for looking into this. yeah, this was just a placeholder issue, so i guess let's open up a nailgun one and keep it referenced

[jhutar]

Created PR SatelliteQE/nailgun#485 with this change. I was unable to run the test because mine Sat is hand-installed so requests.exceptions.SSLError: HTTPSConnectionPool(host='sat630.example.com', port=443): Max retries exceeded with url: /pulp/repos/fksCpkEtnjvN/Library/custom/bQASRMxJp/jlbvdiCh/repodata/repomd.xml (Caused by SSLError(SSLError(336445449, '[SSL] PEM lib (_ssl.c:3405)'),)). I assume that is because of mine config.

[ldjebran]

@jhutar no the problem was about the saved saved value that was not correctly returned as we should use decode('utf-8')

Think it seems to be more complicated to resolve that on nailgun perhaps fix the test to decode that returned value will be the simplest way to resolve this issue.

...
        with self.assertRaises(SSLError):
            client.get(repo_data_file_url, verify=False)
        # get the organization debug certificate
        cert_content = self.org.download_debug_certificate().decode('utf-8')
        # save the organization debug certificate to file
        cert_file_path = '{0}/{1}.pem'.format(
            tempfile.gettempdir(), self.org.label)
        with open(cert_file_path, 'w') as cert_file:
            cert_file.write(cert_content)
        # access repository data with organization debug certificate
        response = client.get(
            repo_data_file_url, cert=cert_file_path, verify=False)
...

This should work in python 2 and python 3

[lpramuk]

+1 couple of similar issues were solved by adding .decode('utf-8')

[jhutar]

Cool. It works with the fix you both proposed in the Nailgun PR:

$ py.test tests/foreman/api/test_repository.py::RepositoryTestCase::test_positive_access_protected_repository
============================= test session starts ==============================
platform linux -- Python 3.6.4, pytest-3.4.0, py-1.5.3, pluggy-0.6.0
shared_function enabled - OFF - scope:  - storage: file
rootdir: /home/pok/Checkouts/robottelo, inifile:
plugins: services-1.2.1, mock-1.6.3
collected 1 item
2018-03-30 00:12:46 - conftest - DEBUG - Collected 1 test cases


tests/foreman/api/test_repository.py .                                   [100%]

============================== 0 tests deselected ==============================
========================== 1 passed in 47.34 seconds ===========================

[jhutar]

SatelliteQE/nailgun#485 merged, so we are good here.