Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't reproduce build #13

Open
NoamDev opened this issue Aug 9, 2020 · 2 comments
Open

Can't reproduce build #13

NoamDev opened this issue Aug 9, 2020 · 2 comments

Comments

@NoamDev
Copy link

NoamDev commented Aug 9, 2020

In order to use this action, I must first reproduce the build to make sure it has been built from the source code.
However, The files I get when trying to build are different from those in the dist folder.

Could you elaborate on your build process?

@NoamDev
Copy link
Author

NoamDev commented Aug 9, 2020

I created to a Dockerfile to allow myself to control any bit of the process.
Can you please try it?

FROM node:12.16.2-slim

# Install latest yarn


# Install node_modules from package.json and yarn.lock
WORKDIR /app/frontend

COPY package.json package-lock.json ./
RUN npm ci

COPY *.js ./
RUN npm run-script package
RUN sha256sum dist/index.js

@jmisur
Copy link
Contributor

jmisur commented Aug 15, 2020

I can definitely build it inside docker container as you shared, but the resulting dist package is indeed different. What I do locally is:

11:26 $ node -v
v12.18.2
11:27 $ npm -v
6.9.0
11:27 $ ncc version
0.23.0
11:27 $ ncc build index.js
ncc: Version 0.23.0
ncc: Compiling file index.js
745kB  dist/index.js
745kB  [1324ms] - ncc 0.23.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants