Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build/test against sjs-dom 2.0.0-RC1 #373

Closed
armanbilge opened this issue Oct 17, 2021 · 3 comments
Closed

Build/test against sjs-dom 2.0.0-RC1 #373

armanbilge opened this issue Oct 17, 2021 · 3 comments

Comments

@armanbilge
Copy link
Contributor

https://github.com/scala-js/scala-js-dom/releases/tag/v2.0.0-RC1

Not sure if this is possible without the react libs on SJS-dom v2.

@oyvindberg
Copy link
Collaborator

Thank you again for the headsup.

ST will be fine, I'm quite sure.

Though you are right that there may be minor complications if one of the react libraries remains stuck for a while on the old version. Likely it can be solved by just generating for the subset of types with the same fully qualified name in scala-js-dom 1 and 2.

@armanbilge
Copy link
Contributor Author

Thanks, I think you are right. The good news is both React libraries seem to be able to upgrade easily: scalajs-react v2 already bumped to 2.0.0-RC1 and I have a PR open for slinky that passes CI.

@oyvindberg
Copy link
Collaborator

oyvindberg commented Oct 26, 2021

Tracked in #377 and #326

Snapshot published as 1.0.0-beta36+27-dc516c4d-SNAPSHOT 1.0.0-beta36+41-906a0cad-SNAPSHOT, it needs this resolver to work:
resolvers += MavenRepository("sonatype-s01-snapshots", "https://s01.oss.sonatype.org/content/repositories/snapshots")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants