fix: error code and message are no longer undefined #134
Conversation
src/helpers/api-error-factory.ts
Outdated
| const { response } = error | ||
| if (response) { | ||
| const { headers, data } = response | ||
| const modelError = data.errors[0] || { |
There was a problem hiding this comment.
@Mykelo Shall we perhaps return an instance of SellingPartnerUnknownError here if data.errors[0] is undefined?
There is no such error class yet, but we can create one.
There was a problem hiding this comment.
It sounds like a better idea! I implemented it in a new commit and I hope this is what you meant.
|
@Mykelo also tests seem to fail. |
|
@moltar there was a problem with tests, because intercepted requests didn't return errors in the format specified by Amazon (here is an example from their repository). I added the required body and tests seem to work now. |
|
For posterity and documentation purposes, this is the place that defines error shapes: https://github.com/amzn/selling-partner-api-docs/blob/main/guides/en-US/developer-guide/SellingPartnerApiDeveloperGuide.md#error-response @Mykelo thank you for your contribution. Merging now, should be released shortly. |
## [3.5.1](v3.5.0...v3.5.1) (2021-06-03) ### Bug Fixes * error code and message are no longer undefined ([#134](#134)) ([55b64b5](55b64b5))
|
🎉 This PR is included in version 3.5.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
What was the problem?
Errors returned by the SDK were kind of useless, because
codeandmessagefields were undefined.Fix
The code assumed that Amazon returns an error as a single object with
codeandmessagefields, but actually they return it as an array of such objects. I made small changes to resolve this issue.